Bug 241225 – [CSS Container Queries] Re-evaluate queries after subframe size changes

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Antti Koivisto]

We fail to update on frame size change.

[Antti Koivisto]

Created attachment 459959 [details]
Patch

[zalan]

Comment on attachment 459959 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=459959&action=review

> Source/WebCore/page/FrameViewLayoutContext.h:58
> +    void layoutWithoutUpdatingQueryContainers();

I assume we are not planning on introducing too many new layout() callsites, so in practice having these 2 functions and deciding "which one to call when" won't cause any issues -but in theory it may be a bit puzzling which one to actually use. I guess if you don't know whether you need query containers, it's better to just use layout().

[Antti Koivisto]

> I assume we are not planning on introducing too many new layout() callsites,
> so in practice having these 2 functions and deciding "which one to call
> when" won't cause any issues -but in theory it may be a bit puzzling which
> one to actually use. I guess if you don't know whether you need query
> containers, it's better to just use layout().

The idea is to just use layout() except in container query related code (there is one other call site for some stupid reasons).

[Antti Koivisto]

Created attachment 459962 [details]
Patch

[Antti Koivisto]

Created attachment 459963 [details]
Patch for landing

[Antti Koivisto]

Created attachment 459964 [details]
Patch

[Antti Koivisto]

Created attachment 459965 [details]
Patch

[Antti Koivisto]

Created attachment 460005 [details]
Patch for landing

[EWS]

Committed r295200 (251257@main): <https://commits.webkit.org/251257@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 460005 [details].

[Radar WebKit Bug Importer]

<rdar://problem/94337695>