Bug 241207 - REGRESSION (250986@main): ASSERTION FAILED: isASCII(characters[I]) in WTF::ASCIILiteral WTF::StringLiterals::operator""_s()
Summary: REGRESSION (250986@main): ASSERTION FAILED: isASCII(characters[I]) in WTF::AS...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-06-01 17:16 PDT by Ryan Haddad
Modified: 2022-06-01 18:25 PDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Haddad 2022-06-01 17:16:20 PDT 
The following API tests are asserting on debug bots:

    TestWTF.WTF_URL.URLSetFragmentIdentifier
        ASSERTION FAILED: isASCII(characters[i])
        /Volumes/Data/worker/Apple-Monterey-Debug-Build/build/WebKitBuild/Debug/usr/local/include/wtf/text/ASCIILiteral.h(89) : WTF::ASCIILiteral WTF::StringLiterals::operator""_s(const char *, size_t)
    TestWTF.WTF_URL.URLSetQuery
        ASSERTION FAILED: isASCII(characters[i])
        /Volumes/Data/worker/Apple-Monterey-Debug-Build/build/WebKitBuild/Debug/usr/local/include/wtf/text/ASCIILiteral.h(89) : WTF::ASCIILiteral WTF::StringLiterals::operator""_s(const char *, size_t)
    TestWTF.WTF_URLParser.Credentials
        ASSERTION FAILED: isASCII(characters[i])
        /Volumes/Data/worker/Apple-Monterey-Debug-Build/build/WebKitBuild/Debug/usr/local/include/wtf/text/ASCIILiteral.h(89) : WTF::ASCIILiteral WTF::StringLiterals::operator""_s(const char *, size_t)
    TestWTF.WTF_URLParser.ParserDifferences
        ASSERTION FAILED: isASCII(characters[i])
        /Volumes/Data/worker/Apple-Monterey-Debug-Build/build/WebKitBuild/Debug/usr/local/include/wtf/text/ASCIILiteral.h(89) : WTF::ASCIILiteral WTF::StringLiterals::operator""_s(const char *, size_t)
    TestWTF.WTF_URLParser.ParserFailures
        ASSERTION FAILED: isASCII(characters[i])
        /Volumes/Data/worker/Apple-Monterey-Debug-Build/build/WebKitBuild/Debug/usr/local/include/wtf/text/ASCIILiteral.h(89) : WTF::ASCIILiteral WTF::StringLiterals::operator""_s(const char *, size_t)
    TestWebKitAPI.HTTPParsers.ParseCrossOriginResourcePolicyHeader
        ASSERTION FAILED: isASCII(characters[i])
        /Volumes/Data/worker/Apple-Monterey-Debug-Build/build/WebKitBuild/Debug/usr/local/include/wtf/text/ASCIILiteral.h(89) : WTF::ASCIILiteral WTF::StringLiterals::operator""_s(const char *, size_t)


https://results.webkit.org/?suite=api-tests&suite=api-tests&suite=api-tests&suite=api-tests&suite=api-tests&suite=api-tests&test=TestWTF.WTF_URL.URLSetFragmentIdentifier&test=TestWTF.WTF_URL.URLSetQuery&test=TestWTF.WTF_URLParser.Credentials&test=TestWTF.WTF_URLParser.ParserDifferences&test=TestWTF.WTF_URLParser.ParserFailures&test=TestWebKitAPI.HTTPParsers.ParseCrossOriginResourcePolicyHeader
Comment 1 Radar WebKit Bug Importer 2022-06-01 17:16:29 PDT 
<rdar://problem/94256662>
Comment 2 Ryan Haddad 2022-06-01 17:17:28 PDT 
Looks like this started with https://commits.webkit.org/250986@main
Comment 3 Chris Dumez 2022-06-01 17:18:19 PDT 
Fixing.
Comment 4 Chris Dumez 2022-06-01 18:21:30 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/1229
Comment 5 EWS 2022-06-01 18:25:06 PDT 
Committed r295114 (251205@main): <https://commits.webkit.org/251205@main>

Reviewed commits have been landed. Closing PR #1229 and removing active labels.