Bug 240754 - Make the StringView(const char*) constructor explicit
Summary: Make the StringView(const char*) constructor explicit
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on: 240687
Blocks:
  Show dependency treegraph
 
Reported: 2022-05-20 23:28 PDT by Chris Dumez
Modified: 2022-06-07 16:36 PDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2022-05-20 23:28:31 PDT
Make the StringView(const char*) constructor private, to encourage people to use ASCIILiteral / ""_s. StringView::fromLatin1() is still available when the caller really has a non-string literal.
Comment 1 Chris Dumez 2022-05-20 23:49:13 PDT
Pull request: https://github.com/WebKit/WebKit/pull/879
Comment 2 Chris Dumez 2022-05-23 11:46:21 PDT
Pull request: https://github.com/WebKit/WebKit/pull/930
Comment 3 EWS 2022-05-25 17:13:48 PDT
Committed r294852 (250986@main): <https://commits.webkit.org/250986@main>

Reviewed commits have been landed. Closing PR #930 and removing active labels.
Comment 4 Radar WebKit Bug Importer 2022-05-25 17:14:17 PDT
<rdar://problem/93937438>