WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
240754
Make the StringView(const char*) constructor explicit
https://bugs.webkit.org/show_bug.cgi?id=240754
Summary
Make the StringView(const char*) constructor explicit
Chris Dumez
Reported
2022-05-20 23:28:31 PDT
Make the StringView(const char*) constructor private, to encourage people to use ASCIILiteral / ""_s. StringView::fromLatin1() is still available when the caller really has a non-string literal.
Attachments
Add attachment
proposed patch, testcase, etc.
Chris Dumez
Comment 1
2022-05-20 23:49:13 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/879
Chris Dumez
Comment 2
2022-05-23 11:46:21 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/930
EWS
Comment 3
2022-05-25 17:13:48 PDT
Committed
r294852
(
250986@main
): <
https://commits.webkit.org/250986@main
> Reviewed commits have been landed. Closing PR #930 and removing active labels.
Radar WebKit Bug Importer
Comment 4
2022-05-25 17:14:17 PDT
<
rdar://problem/93937438
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug