RESOLVED FIXED Bug 240807
[GPU Process] [Filters] Make PixelBuffer a RefCounted class 
https://bugs.webkit.org/show_bug.cgi?id=240807
Summary [GPU Process] [Filters] Make PixelBuffer a RefCounted class
Said Abou-Hallawa
Reported 2022-05-23 09:01:54 PDT
The plan is to hide the underlying memory of PixelBuffer. GPUProcess needs to allocate shared memory and attribute it to the WebProcess. Currently the PixelBuffer is created as std::optional<PixelBuffer> which does not allow sub-classing it. We need to create PixelBuffer as a pointer. In the software filter appliers code, there are instances that we need to ref-count the underlying memory 'Uint8ClampedArray' see FEGaussianBlurSoftwareApplier::ApplyParameters.
Attachments
Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2022-05-27 10:09:18 PDT
<rdar://problem/94040771>
Said Abou-Hallawa
Comment 2 2022-05-27 10:16:37 PDT
Pull request: https://github.com/WebKit/WebKit/pull/1101
EWS
Comment 3 2022-06-01 18:08:08 PDT
Committed r295113 (251204@main): <https://commits.webkit.org/251204@main> Reviewed commits have been landed. Closing PR #1101 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.