WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
240732
[git-webkit] Use --git-common-dir over hard-coded .git
https://bugs.webkit.org/show_bug.cgi?id=240732
Summary
[git-webkit] Use --git-common-dir over hard-coded .git
Jonathan Bedard
Reported
2022-05-20 13:49:58 PDT
As Sam Sneddon pointed out, using a hard coded .git to find our config location will break if folks are using git work trees. We should use `git rev-parse --git-common-dir` instead.
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2022-05-20 13:50:14 PDT
<
rdar://problem/93676555
>
Jonathan Bedard
Comment 2
2022-05-20 13:54:55 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/851
Alexey Proskuryakov
Comment 3
2022-05-20 18:08:25 PDT
***
Bug 240682
has been marked as a duplicate of this bug. ***
EWS
Comment 4
2022-05-26 14:56:37 PDT
Committed
r294900
(
251023@main
): <
https://commits.webkit.org/251023@main
> Reviewed commits have been landed. Closing PR #851 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug