RESOLVED DUPLICATE of bug 240732 240682
git-webkit setup fails when run within a worktree 
https://bugs.webkit.org/show_bug.cgi?id=240682
Summary git-webkit setup fails when run within a worktree
Sam Sneddon [:gsnedders]
Reported 2022-05-19 13:08:29 PDT
INFO:webkitscmpy:Configuring and copying hook /Volumes/gsnedders/projects/Safari-CSSPropertyEnabled/OpenSource/Tools/Scripts/hooks/prepare-commit-msg for this repository Downloading jinja2-2.11.3... Installing jinja2-2.11.3... Installed jinja2-2.11.3! Downloading MarkupSafe-1.1.1... Installing MarkupSafe-1.1.1... Installed MarkupSafe-1.1.1! Traceback (most recent call last): File "/Volumes/gsnedders/projects/Safari-CSSPropertyEnabled/OpenSource/./Tools/Scripts/git-webkit", line 69, in <module> sys.exit(program.main( File "/Volumes/gsnedders/projects/Safari-CSSPropertyEnabled/OpenSource/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/__init__.py", line 147, in main return parsed.main( File "/Volumes/gsnedders/projects/Safari-CSSPropertyEnabled/OpenSource/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/setup.py", line 493, in main result = cls.git(args, repository, **kwargs) File "/Volumes/gsnedders/projects/Safari-CSSPropertyEnabled/OpenSource/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/setup.py", line 289, in git os.makedirs(os.path.dirname(target)) File "/AppleInternal/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/os.py", line 225, in makedirs mkdir(name, mode) NotADirectoryError: [Errno 20] Not a directory: '/Volumes/gsnedders/projects/Safari-CSSPropertyEnabled/OpenSource/.git/hooks' When setting up hooks etc. we should be writing into "$( git rev-parse --git-common-dir )/hooks".
Attachments
Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2022-05-20 18:08:25 PDT
*** This bug has been marked as a duplicate of bug 240732 ***
Note You need to log in before you can comment on or make changes to this bug.