RESOLVED DUPLICATE of bug 239665 240701
"No new tests (OOPS!)." is ending up in the middle of commit messages 
https://bugs.webkit.org/show_bug.cgi?id=240701
Summary "No new tests (OOPS!)." is ending up in the middle of commit messages
Simon Fraser (smfr)
Reported 2022-05-19 20:49:01 PDT
The pre-filled commit message for https://github.com/WebKit/WebKit/pull/814 ended up like: 5dd145e ASSERT(status == U_ZERO_ERROR) under SearchBuffer::search() when typing in the url bar in the iOS simulator https://bugs.webkit.org/show_bug.cgi?id=240699 <rdar://92182174> Reviewed by NOBODY (OOPS!). Replace `status == U_ZERO_ERROR` tests with `U_SUCCESS(status)`. * Source/WebCore/PAL/pal/text/TextCodecICU.cpp: (PAL::ErrorCallbackSetter::ErrorCallbackSetter): (PAL::ErrorCallbackSetter::~ErrorCallbackSetter): * Source/WebKit/UIProcess/Cocoa/ModalContainerControlClassifier.mm: (WebKit::SpoofChecker::checker): No new tests (OOPS!). * Source/WebCore/editing/TextIterator.cpp: (WebCore::createSearcher): (WebCore::SearchBuffer::SearchBuffer): (WebCore::SearchBuffer::~SearchBuffer): (WebCore::SearchBuffer::search): Note "No new tests (OOPS!)." in the middle which I totally missed.
Attachments
Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2022-05-26 20:49:13 PDT
<rdar://problem/94013879>
Ryan Haddad
Comment 2 2022-07-01 14:42:35 PDT
*** Bug 239665 has been marked as a duplicate of this bug. ***
Ryan Haddad
Comment 3 2022-07-01 14:43:32 PDT
Duped the wrong way, sorry! *** This bug has been marked as a duplicate of bug 239665 ***
Note You need to log in before you can comment on or make changes to this bug.