Bug 239665 - "No new tests (OOPS!)." appears in wrong place in the commit message
Summary: "No new tests (OOPS!)." appears in wrong place in the commit message
Status: REOPENED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
: 240701 (view as bug list)
Depends on:
Blocks: 239082
  Show dependency tree / graph
 
Reported: 2022-04-22 12:07 PDT by Chris Dumez
Modified: 2022-07-01 14:43 PDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2022-04-22 12:07:02 PDT 
"No new tests (OOPS!)." appears in wrong place in the commit message when using the new GIT commit hook:

Start preparing the code base for making the AtomString(const String&) constructor explicit
https://bugs.webkit.org/show_bug.cgi?id=239658

Reviewed by NOBODY (OOPS!).

Start preparing the code base for making the AtomString(const String&) constructor explicit.
This helps us find cases where we atomize unnecessarily or not early enough, thus causing
unnecessary String allocations.

* Source/JavaScriptCore/runtime/JSString.cpp:
(JSC::JSRopeString::resolveRopeToAtomString const):
* Source/WebKit/WebProcess/Plugins/Plugin.h:
* Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::createPlugin):
* Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
* Source/WebKitLegacy/mac/DOM/DOMCustomXPathNSResolver.h:
* Source/WebKitLegacy/mac/DOM/DOMCustomXPathNSResolver.mm:
(DOMCustomXPathNSResolver::lookupNamespaceURI):
* Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.h:
* Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.mm:
(parameterValue):
(WebFrameLoaderClient::createPlugin):
* Source/WebKitLegacy/win/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::createPlugin):
* Source/WebKitLegacy/win/WebCoreSupport/WebFrameLoaderClient.h:
* Source/WTF/wtf/persistence/PersistentCoders.cpp:
(WTF::Persistence::Coder<AtomString>::decode):
* Source/WTF/wtf/text/StringBuilder.h:
(WTF::StringBuilder::toAtomString const):
* Source/WTF/wtf/text/StringConcatenate.h:
(WTF::tryMakeAtomStringFromAdapters):
* Source/WTF/wtf/text/StringView.cpp:
(WTF::convertASCIILowercaseAtom):
No new tests (OOPS!). // WHY IS THIS HERE?
* Source/WebCore/Modules/gamepad/GamepadEvent.idl:
* Source/WebCore/Modules/mediasession/MediaMetadata.cpp:
(WebCore::ArtworkImageLoader::requestImageResource):
* Source/WebCore/Modules/plugins/PluginReplacement.h:
(WebCore::ReplacementPlugin::create const):
Comment 1 Radar WebKit Bug Importer 2022-04-29 12:07:14 PDT 
<rdar://problem/92537106>
Comment 2 Chris Dumez 2022-04-29 12:08:02 PDT 
This is sooo annoying. I keep missing the ""No new tests (OOPS!)." because it is hidden among the many modified files and then the patch fails to commit :(
Comment 3 Ryan Haddad 2022-07-01 14:42:35 PDT 

*** This bug has been marked as a duplicate of bug 240701 ***
Comment 4 Ryan Haddad 2022-07-01 14:43:12 PDT 
Duped the wrong way, sorry.
Comment 5 Ryan Haddad 2022-07-01 14:43:32 PDT 
*** Bug 240701 has been marked as a duplicate of this bug. ***