RESOLVED FIXED 239924
Web Inspector: Update jsmin to 3.0.1 
https://bugs.webkit.org/show_bug.cgi?id=239924
Summary Web Inspector: Update jsmin to 3.0.1
Philippe Normand
Reported 2022-04-30 01:57:40 PDT
Current version (2.0.9) is very slow: time python /app/webkit/Source/JavaScriptCore/Scripts/jsmin.py < /app/webkit/WebKitBuild/Release/WebInspectorUI/DerivedSources/Main.js > foo.js real 1m21.234s user 0m59.580s sys 0m21.253s Version 3.0.1 is much faster: time python /app/webkit/Source/JavaScriptCore/Scripts/jsmin.py < /app/webkit/WebKitBuild/Release/WebInspectorUI/DerivedSources/Main.js > foo.js real 0m3.933s user 0m3.899s sys 0m0.018s So I'll try an update.
Attachments
Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 2022-04-30 02:22:35 PDT
Pull request: https://github.com/WebKit/WebKit/pull/444
EWS
Comment 2 2022-05-04 02:13:05 PDT
Committed r293767 (250246@main): <https://commits.webkit.org/250246@main> Reviewed commits have been landed. Closing PR #444 and removing active labels.
Radar WebKit Bug Importer
Comment 3 2022-05-04 02:14:13 PDT
<rdar://problem/92720918>
Truitt Savell
Comment 4 2022-05-10 15:30:23 PDT
It looks like the changes in https://github.com/WebKit/WebKit/commit/057f942c764e9f79d38e88bca94b7e35549883b4 broke inspector/timeline/line-column.html tracking in: https://bugs.webkit.org/show_bug.cgi?id=240291
Patrick Angle
Comment 5 2022-06-28 15:03:46 PDT
This broke minifying WebInspectorUI. Specifically, the comment in CodeMirrorCompletionController.js `// FIXME: Include module keywords if we know this is a module environment.` is being kept in the minified output, most likely due to the regex above in the file. It appears to be this issue in the upstream project: https://github.com/tikitu/jsmin/issues/23
Note You need to log in before you can comment on or make changes to this bug.