Bug 240291 - REGRESSION (250246@main): [ Mac ] inspector/timeline/line-column.html is failing
Summary: REGRESSION (250246@main): [ Mac ] inspector/timeline/line-column.html is failing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Truitt Savell
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-05-10 15:29 PDT by Truitt Savell
Modified: 2022-05-10 15:56 PDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Truitt Savell 2022-05-10 15:29:09 PDT 
inspector/timeline/line-column.html

This test is a constant failure. this seems like it might just be a rebase that's needed after the changes in https://github.com/WebKit/WebKit/commit/057f942c764e9f79d38e88bca94b7e35549883b4

History:
https://results.webkit.org/?suite=layout-tests&test=inspector%2Ftimeline%2Fline-column.html

Diff:
--- /Volumes/Data/worker/Apple-Monterey-Release-AppleSilicon-WK2-Tests/build/layout-test-results/inspector/timeline/line-column-expected.txt
+++ /Volumes/Data/worker/Apple-Monterey-Release-AppleSilicon-WK2-Tests/build/layout-test-results/inspector/timeline/line-column-actual.txt
@@ -64,7 +64,7 @@
               "functionName": "",
               "url": "",
               "scriptId": "<filtered>",
-              "lineNumber": 142,
+              "lineNumber": 141,
               "columnNumber": 97
             }
           ],
@@ -117,7 +117,7 @@
           "functionName": "",
           "url": "",
           "scriptId": "<filtered>",
-          "lineNumber": 142,
+          "lineNumber": 141,
           "columnNumber": 97
         }
       ],
@@ -177,7 +177,7 @@
           "functionName": "",
           "url": "",
           "scriptId": "<filtered>",
-          "lineNumber": 142,
+          "lineNumber": 141,
           "columnNumber": 97
         }
       ],
Comment 1 Radar WebKit Bug Importer 2022-05-10 15:29:49 PDT 
<rdar://problem/93058318>
Comment 2 Truitt Savell 2022-05-10 15:31:57 PDT 
yes, this test was rebased on gtk, not on MacOS though
Comment 3 Truitt Savell 2022-05-10 15:49:56 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/582
Comment 4 EWS 2022-05-10 15:53:53 PDT 
Test gardening commit r294029 (250453@main): <https://commits.webkit.org/250453@main>

Reviewed commits have been landed. Closing PR #582 and removing active labels.