RESOLVED FIXED 23985
Crash on WebCore::InlineFlowBox::addToLine 
https://bugs.webkit.org/show_bug.cgi?id=23985
Summary Crash on WebCore::InlineFlowBox::addToLine
Dimitri Glazkov (Google)
Reported 2009-02-16 19:27:30 PST
This bug was initially filed here http://crbug.com/7775. Stack trace coming up (see Chromium's for information for now).
Attachments
Crash log (34.03 KB, text/plain)
2009-02-16 20:23 PST, Dimitri Glazkov (Google) 		no flags
Details
Rendering slowness reduction. (287 bytes, text/html)
2009-02-17 10:04 PST, Dimitri Glazkov (Google) 		no flags
Details
Force legends to be display:block (1.65 KB, patch)
2009-02-17 10:17 PST, Dave Hyatt 		no flags
DetailsFormatted DiffDiff
Force legends to be display:block (931 bytes, patch)
2009-02-17 10:18 PST, Dave Hyatt 		no flags
DetailsFormatted DiffDiff
Force legends to be display:block and eliminate the RenderLegend that caused the trouble in the first place (12.77 KB, patch)
2009-02-17 10:30 PST, Dave Hyatt 		hyatt: review-
DetailsFormatted DiffDiff
Force legends to be display:block (60.61 KB, patch)
2009-02-17 10:51 PST, Dave Hyatt 		eric: review+
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Dimitri Glazkov (Google)
Comment 1 2009-02-16 20:23:30 PST
Created attachment 27717 [details] Crash log Here's the crash log. Working on reduction ...
Dimitri Glazkov (Google)
Comment 2 2009-02-17 10:04:20 PST
Created attachment 27732 [details] Rendering slowness reduction. Ok, this is interesting. Here's a reduction that doesn't cause a crash, but it definitely hangs the renderer for a while (up to 30 secs on my machine) and produces clearly invalid output.
Dave Hyatt
Comment 3 2009-02-17 10:17:52 PST
Created attachment 27733 [details] Force legends to be display:block
Dave Hyatt
Comment 4 2009-02-17 10:18:28 PST
Created attachment 27734 [details] Force legends to be display:block
Dave Hyatt
Comment 5 2009-02-17 10:19:19 PST
This patch fixes the rendering issues with this test case (and another one Dan pointed out to me a week or so ago). It might still be worth investigating how we hit the assert in createLineBoxes when we let the legend be inline.
Dave Hyatt
Comment 6 2009-02-17 10:30:06 PST
Created attachment 27735 [details] Force legends to be display:block and eliminate the RenderLegend that caused the trouble in the first place
Dave Hyatt
Comment 7 2009-02-17 10:32:24 PST
Comment on attachment 27735 [details] Force legends to be display:block and eliminate the RenderLegend that caused the trouble in the first place Need new changelog and a test case. Minusing myself.
Dave Hyatt
Comment 8 2009-02-17 10:51:55 PST
Created attachment 27737 [details] Force legends to be display:block
Dimitri Glazkov (Google)
Comment 9 2009-02-17 10:53:57 PST
It's gorgeous. Somebody r+ this!
Eric Seidel (no email)
Comment 10 2009-02-17 11:27:36 PST
Comment on attachment 27737 [details] Force legends to be display:block Looks fine. I can't claim to be an expert here, but Hyatt's change looks sane to me.
Dave Hyatt
Comment 11 2009-02-17 11:34:02 PST
Fixed in r41041.
Jon@Chromium
Comment 12 2009-02-17 15:43:20 PST
*** Bug 23998 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.