Bug 239805 - [GCC] GCC9.3 defines 'remove_cvref_t' but not '__cpp_lib_remove_cvref'
Summary: [GCC] GCC9.3 defines 'remove_cvref_t' but not '__cpp_lib_remove_cvref'
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Diego Pino
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-04-27 00:20 PDT by Diego Pino
Modified: 2022-04-28 20:18 PDT (History)
7 users (show)

See Also:

Attachments
Patch (1.98 KB, patch)
2022-04-27 00:22 PDT, Diego Pino 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Pino 2022-04-27 00:20:05 PDT 
[GCC] GCC9.3 defines 'remove_cvref_t' but not '__cpp_lib_remove_cvref'
Comment 1 Diego Pino 2022-04-27 00:22:17 PDT 
Created attachment 458424 [details]
Patch
Comment 2 Diego Pino 2022-04-27 00:25:58 PDT 
Because of this bug Ubuntu 20.04 build bot is failing:

https://build.webkit.org/#/builders/30/builds/442/steps/9/logs/stdio
Comment 3 EWS 2022-04-27 05:01:09 PDT 
Committed r293505 (250036@main): <https://commits.webkit.org/250036@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 458424 [details].
Comment 4 Radar WebKit Bug Importer 2022-04-27 05:02:13 PDT 
<rdar://problem/92391267>
Comment 5 Alexey Proskuryakov 2022-04-28 20:11:28 PDT 
Comment on attachment 458424 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=458424&action=review

> Source/WTF/wtf/StdLibExtras.h:608
> +// TODO: Needed for GCC<=9.3. Remove it after Ubuntu 20.04 end of support (May 2023).

Please use FIXME, not TODO: https://webkit.org/code-style-guidelines/
Comment 6 Diego Pino 2022-04-28 20:18:36 PDT 
This patch broke Debian 10 build bot since __cplusplus value is 201709L for GCC8.3. 

https://build.webkit.org/#/builders/46/builds/13047/steps/8/logs/stdio

Follow-up in https://bugs.webkit.org/show_bug.cgi?id=239881