Bug 239482 – REGRESSION(r292863): std::remove_cvref_t not defined in GCC9<

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Diego Pino]

REGRESSION(r292863): std::remove_cvref_t not defined in GCC9<

[Diego Pino]

Created attachment 457858 [details]
Patch

[Daniel Kolesa]

should probably make it conditional for `__GLIBCXX__` to avoid affecting libc++ environments (like mac)

[Diego Pino]

Created attachment 457907 [details]
Patch

[Zan Dobersek]

Comment on attachment 457907 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=457907&action=review

> Source/WTF/wtf/StdLibExtras.h:612
> +template <typename T>
> +struct remove_cvref {
> +    using type = typename std::remove_cv<typename std::remove_reference<T>::type>::type;
> +};

This has to be in the std namespace too.

[Diego Pino]

Created attachment 458032 [details]
Patch

[EWS]

[e-mail] does not have committer permissions according to https://raw.githubusercontent.com/WebKit/WebKit/main/metadata/contributors.json.

Rejecting attachment 458032 [details] from commit queue.

[EWS]

[e-mail] does not have reviewer permissions according to https://raw.githubusercontent.com/WebKit/WebKit/main/metadata/contributors.json.

Rejecting attachment 458032 [details] from commit queue.

[EWS]

Committed r293148 (249844@main): <https://commits.webkit.org/249844@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 458032 [details].

[Ryan Haddad]

rdar://92082938