Bug 239734 - [css-logical] Border side shorthands should not be logical/physical
Summary: [css-logical] Border side shorthands should not be logical/physical
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Oriol Brufau
URL:
Keywords: InRadar
Depends on:
Blocks: 236199 238888
  Show dependency treegraph
 
Reported: 2022-04-25 11:23 PDT by Oriol Brufau
Modified: 2022-04-26 19:03 PDT (History)
12 users (show)

See Also:


Attachments
Patch (8.61 KB, patch)
2022-04-25 11:49 PDT, Oriol Brufau
no flags Details | Formatted Diff | Diff
Patch (9.56 KB, patch)
2022-04-25 12:00 PDT, Oriol Brufau
no flags Details | Formatted Diff | Diff
Patch (10.53 KB, patch)
2022-04-26 08:54 PDT, Oriol Brufau
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Oriol Brufau 2022-04-25 11:23:18 PDT
Currently, these shorthands belong to a logical property group:

 - border-top
 - border-right
 - border-bottom
 - border-left
 - border-block-start
 - border-block-end
 - border-inline-start
 - border-inline-end

This doesn't make much sense, no need to e.g. map border-block-start to border-top, it should just expand to border-block-start-{width,style,color}.
Then we can keep the special behavior confined to the longhands.

Right now I don't think this is observable, but this refactoring is needed for bug 236199.
My patch there (including this change) was previously reverted, so I guess it's safer to do the refactoring here.
Comment 1 Oriol Brufau 2022-04-25 11:43:07 PDT
This change will also align the implementation with the spec: https://drafts.csswg.org/css-logical/#box

> Each set of parallel flow-relative properties and physical properties (IGNORING SHORTHAND PROPERTIES) related by setting equivalent styles on the various sides or dimensions of a box, forms a logical property group.
Comment 2 Oriol Brufau 2022-04-25 11:49:07 PDT
Created attachment 458288 [details]
Patch
Comment 3 Oriol Brufau 2022-04-25 12:00:02 PDT
Created attachment 458290 [details]
Patch
Comment 4 Tim Nguyen (:ntim) 2022-04-25 17:27:24 PDT
Comment on attachment 458290 [details]
Patch

Thanks for fixing this!
Comment 5 Oriol Brufau 2022-04-26 08:54:16 PDT
Created attachment 458372 [details]
Patch
Comment 6 Oriol Brufau 2022-04-26 08:55:15 PDT
Had to update CSSPropertyAnimation.cpp to avoid an assert failure in debug.
Comment 7 EWS 2022-04-26 19:02:44 PDT
Committed r293493 (250026@main): <https://commits.webkit.org/250026@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 458372 [details].
Comment 8 Radar WebKit Bug Importer 2022-04-26 19:03:24 PDT
<rdar://problem/92372140>