WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
239668
[Wasm-GC] Add support for subtyping declarations
https://bugs.webkit.org/show_bug.cgi?id=239668
Summary
[Wasm-GC] Add support for subtyping declarations
Asumu Takikawa
Reported
2022-04-22 12:31:55 PDT
As mentioned in
https://bugs.webkit.org/show_bug.cgi?id=239666
, full support of the Wasm GC proposal requires type system support for both recursion groups and subtyping declarations. In the latest GC proposal design, subtyping (e.g., for struct types) is declared explicitly with a `sub` operator: Example: ``` (module (type $s1 (struct)) (type $s2 (sub $s1 (field i32))) ) ``` The binary format allows for multiple supertypes, but the MVP design will restrict it to one supertype. A reference type with an index to a type definition that has supertypes will be compatible with a reference type to its supertype index. Only array and struct types will support subtyping at first, so it likely makes sense to implement this after struct operations and recursive types land.
Attachments
Add attachment
proposed patch, testcase, etc.
Asumu Takikawa
Comment 1
2022-04-22 12:32:54 PDT
There was a mistake in the example, it should have a `struct` operator in there: ``` (module (type $s1 (struct)) (type $s2 (sub $s1 (struct (field i32)))) ) ```
Radar WebKit Bug Importer
Comment 2
2022-04-29 12:32:12 PDT
<
rdar://problem/92538296
>
Asumu Takikawa
Comment 3
2022-10-25 16:14:44 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/5786
EWS
Comment 4
2022-11-02 14:23:53 PDT
Committed
256243@main
(431164ca6a4b): <
https://commits.webkit.org/256243@main
> Reviewed commits have been landed. Closing PR #5786 and removing active labels.
bashorov
Comment 5
2022-11-02 16:14:22 PDT
I'm wondering if there is an umbrella issue to track progress about GC proposal support? Also, could you please suggest how I may try current state in the Safari(I guess in Technology Preview)? Specifically how I cen turn on relevant options in Safari?
Asumu Takikawa
Comment 6
2022-11-02 17:20:05 PDT
(In reply to bashorov from
comment #5
)
> I'm wondering if there is an umbrella issue to track progress about GC > proposal support? > > Also, could you please suggest how I may try current state in the Safari(I > guess in Technology Preview)? Specifically how I cen turn on relevant > options in Safari?
I just created an umbrella bug for GC here:
https://bugs.webkit.org/show_bug.cgi?id=247394
There is still a bunch of work needed to run non-trivial Wasm GC programs, but a subset of the spec tests will pass. There is a `--useWebAssemblyGC` flag for JSC that you can toggle if you build JSC standalone. Not sure it is exposed via WebKit and visible in the Safari UI though.
bashorov
Comment 7
2022-11-03 04:41:44 PDT
> I just created an umbrella bug for GC
Cool, thanks!
> Not sure it is exposed via WebKit and visible in the Safari UI though.
Where/who is right place/person to ask about it?
David Degazio
Comment 8
2024-07-24 15:25:15 PDT
***
Bug 233919
has been marked as a duplicate of this bug. ***
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug