Though rtt types currently not actively used they are still required in Wasm GC MVP: https://github.com/WebAssembly/gc/blob/main/proposals/gc/MVP.md. Particularly, they are needed for struct.new* instructions, but struct constructors can avoid rtts usage. Because of all that rtt prototype support should be added in JSC to move forward with struct types.
Created attachment 457883 [details] Patch
This patch modifies one of the wasm.json files. Please ensure that any changes in one have been mirrored to the other. You can find the wasm.json files at "Source/JavaScriptCore/wasm/wasm.json" and "JSTests/wasm/wasm.json".
Created attachment 458242 [details] Patch
Comment on attachment 458242 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=458242&action=review Looks good to me but you have a typo in your error message. > Source/JavaScriptCore/wasm/WasmFunctionParser.h:1052 > + WASM_VALIDATOR_FAIL_IF(typeIndex >= m_info.typeCount(), "rtt.canon index ", typeIndex, " is out of bound"); typo: bound => bounds.
Created attachment 458329 [details] Patch
Thanks for the typo, Keith! It was fixed.
Comment on attachment 458329 [details] Patch r=me. Do you want me to commit queue too?
<rdar://problem/92329753>
Committed r293510 (?): <https://commits.webkit.org/r293510> All reviewed patches have been landed. Closing bug and clearing flags on attachment 458329 [details].
Committed r294395 (250689@main): <https://commits.webkit.org/250689@main> Reviewed commits have been landed. Closing PR #607 and removing active labels.