Bug 239016 - [GTK][WPE] Missing inter-module documentation links
Summary: [GTK][WPE] Missing inter-module documentation links
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adrian Perez
URL:
Keywords: InRadar
Depends on:
Blocks: 242900
  Show dependency tree / graph
 
Reported: 2022-04-08 13:55 PDT by Adrian Perez
Modified: 2022-07-19 08:23 PDT (History)
15 users (show)

See Also:

Attachments
Patch (12.56 KB, patch)
2022-04-08 14:07 PDT, Adrian Perez 		no flags Details | Formatted Diff | Diff
Patch v2 (12.55 KB, patch)
2022-04-08 14:28 PDT, Adrian Perez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adrian Perez 2022-04-08 13:55:25 PDT 
After the switch to gi-docgen in #226662 the generated documentation
no longer has functioning links to other modules. We would want to
have references to e.g. GObject or GTK functions and types with usable
links :)
Comment 1 Adrian Perez 2022-04-08 14:07:08 PDT 
Created attachment 457116 [details]
Patch
Comment 2 Adrian Perez 2022-04-08 14:27:43 PDT 
Comment on attachment 457116 [details]
Patch

I found a small issue with the patch myself. I'll reupload a fixed v2.

View in context: https://bugs.webkit.org/attachment.cgi?id=457116&action=review

> Source/WebKit/gtk/urlmap.js.in:12
> +  ["JavaScriptCore", "../javascriptcoregtk-" + baseURLApiLevelSuffix],

The trailing dash here is not needed, because there is a dash already as
the first character of the “baseURLApiLevelSuffix” variable.
Comment 3 Adrian Perez 2022-04-08 14:28:26 PDT 
Created attachment 457117 [details]
Patch v2
Comment 4 EWS 2022-04-09 01:36:16 PDT 
Committed r292678 (249470@main): <https://commits.webkit.org/249470@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 457117 [details].
Comment 5 Radar WebKit Bug Importer 2022-04-09 01:37:16 PDT 
<rdar://problem/91518259>