WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
239016
[GTK][WPE] Missing inter-module documentation links
https://bugs.webkit.org/show_bug.cgi?id=239016
Summary
[GTK][WPE] Missing inter-module documentation links
Adrian Perez
Reported
2022-04-08 13:55:25 PDT
After the switch to gi-docgen in #226662 the generated documentation no longer has functioning links to other modules. We would want to have references to e.g. GObject or GTK functions and types with usable links :)
Attachments
Patch
(12.56 KB, patch)
2022-04-08 14:07 PDT
,
Adrian Perez
no flags
Details
Formatted Diff
Diff
Patch v2
(12.55 KB, patch)
2022-04-08 14:28 PDT
,
Adrian Perez
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Adrian Perez
Comment 1
2022-04-08 14:07:08 PDT
Created
attachment 457116
[details]
Patch
Adrian Perez
Comment 2
2022-04-08 14:27:43 PDT
Comment on
attachment 457116
[details]
Patch I found a small issue with the patch myself. I'll reupload a fixed v2. View in context:
https://bugs.webkit.org/attachment.cgi?id=457116&action=review
> Source/WebKit/gtk/urlmap.js.in:12 > + ["JavaScriptCore", "../javascriptcoregtk-" + baseURLApiLevelSuffix],
The trailing dash here is not needed, because there is a dash already as the first character of the “baseURLApiLevelSuffix” variable.
Adrian Perez
Comment 3
2022-04-08 14:28:26 PDT
Created
attachment 457117
[details]
Patch v2
EWS
Comment 4
2022-04-09 01:36:16 PDT
Committed
r292678
(
249470@main
): <
https://commits.webkit.org/249470@main
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 457117
[details]
.
Radar WebKit Bug Importer
Comment 5
2022-04-09 01:37:16 PDT
<
rdar://problem/91518259
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug