Bug 238803 – [Forms] Use button instead of push-button appearance for input[type=submit|reset|button]

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Tim Nguyen (:ntim)]

A couple of tests in html/rendering/widgets/button-layout/ are expecting <input type=submit|reset|button> to look the same as <button>, making them the same appearance would be a good first step.

[Tim Nguyen (:ntim)]

One important bug switching from button to push-button fixes is:

Code: <input type=button value="1&#10;2">

Testcase URL: data:text/html,%3Cinput type%3Dbutton value%3D"1%26%2310%3B2"%3E

Should appear the same as: <button>1<br>2</button>

Right now it appears as: <button>1</button>

Tested by html/rendering/widgets/button-layout/inline-level.html WPT

[Tim Nguyen (:ntim)]

<input type=button> does not respect author sizing (padding/height/etc.), while <button> does. <button> behavior is more in line with other browsers, switching from push-button to button appearance fixes this.

[Tim Nguyen (:ntim)]

Created attachment 456715 [details]
Patch

[Radar WebKit Bug Importer]

<rdar://problem/91624840>

[Tim Nguyen (:ntim)]

*** Bug 190521 has been marked as a duplicate of this bug. ***

[Tim Nguyen (:ntim)]

Created attachment 463716 [details]
Patch

[Tim Nguyen (:ntim)]

Work needed here is mostly rebaselining, it would be nice to fix this so multi-line text and padding are respected for `<input type="submit/reset/button">`.

[Tim Nguyen (:ntim)]

(also makes vertical form controls slightly easier to implement)

[Tim Nguyen (:ntim)]

Pull request: https://github.com/WebKit/WebKit/pull/8440

[EWS]

Committed 258754@main (1a0105921def): <https://commits.webkit.org/258754@main>

Reviewed commits have been landed. Closing PR #8440 and removing active labels.

[Tim Nguyen (:ntim)]

*** Bug 224746 has been marked as a duplicate of this bug. ***

[Ahmad Saleem]

*** Bug 26804 has been marked as a duplicate of this bug. ***