Bug 238542 - [CSS Container Queries] Keep colon syntax when serializing container condition
Summary: [CSS Container Queries] Keep colon syntax when serializing container condition
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antti Koivisto
URL:
Keywords: InRadar
Depends on:
Blocks: 229659 238346
  Show dependency tree / graph
 
Reported: 2022-03-30 02:31 PDT by Antti Koivisto
Modified: 2022-03-30 13:22 PDT (History)
11 users (show)

See Also:

Attachments
Patch (12.47 KB, patch)
2022-03-30 02:37 PDT, Antti Koivisto 		no flags Details | Formatted Diff | Diff
Patch (12.47 KB, patch)
2022-03-30 06:57 PDT, Antti Koivisto 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2022-03-30 02:31:12 PDT 
Instead of always serializing using the range syntax.
Comment 1 Antti Koivisto 2022-03-30 02:37:14 PDT 
Created attachment 456105 [details]
Patch
Comment 2 EWS Watchlist 2022-03-30 02:38:51 PDT 
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess
Comment 3 Antti Koivisto 2022-03-30 06:57:59 PDT 
Created attachment 456116 [details]
Patch
Comment 4 Antti Koivisto 2022-03-30 06:58:24 PDT 
Submitted web-platform-tests pull request: https://github.com/web-platform-tests/wpt/pull/33423
Comment 5 Tim Nguyen (:ntim) 2022-03-30 10:10:40 PDT 
Comment on attachment 456116 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=456116&action=review

> Source/WebCore/css/ContainerQuery.cpp:164
> +    case Syntax::Range:

Maybe assert that at least one of leftComparison or rightComparison is present.
Comment 6 Antti Koivisto 2022-03-30 10:52:42 PDT 
> Maybe assert that at least one of leftComparison or rightComparison is
> present.

That's really just the boolean syntax case though I separated it for clarity.
Comment 7 EWS 2022-03-30 13:21:34 PDT 
Committed r292117 (249030@main): <https://commits.webkit.org/249030@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 456116 [details].
Comment 8 Radar WebKit Bug Importer 2022-03-30 13:22:27 PDT 
<rdar://problem/91063095>