Bug 238373 – Import clip-path W3C tests

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Noam Rosenthal]

Importing in preparation for CSS shape()

[Noam Rosenthal]

Created attachment 455749 [details]
Patch

[Tim Nguyen (:ntim)]

Comment on attachment 455749 [details]
Patch

LGTM, but please address ios-wk2 failures before landing.

[Noam Rosenthal]

(In reply to Tim Nguyen (:ntim) from comment #2)
> Comment on attachment 455749 [details]
> Patch
> 
> LGTM, but please address ios-wk2 failures before landing.

Thanks, will do
Probably a matter of adding fuzz meta, will look into it.

[Noam Rosenthal]

Created attachment 455837 [details]
Patch

[EWS]

Committed r291949 (248916@main): <https://commits.webkit.org/248916@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 455837 [details].

[Radar WebKit Bug Importer]

<rdar://problem/90887333>

[Tim Nguyen (:ntim)]

(In reply to Noam Rosenthal from comment #3)
> (In reply to Tim Nguyen (:ntim) from comment #2)
> > Comment on attachment 455749 [details]
> > Patch
> > 
> > LGTM, but please address ios-wk2 failures before landing.
> 
> Thanks, will do
> Probably a matter of adding fuzz meta, will look into it.

Can you export those changes to the WPT repo? Otherwise, they'll get lost at the next import.

[Noam Rosenthal]

(In reply to Tim Nguyen (:ntim) from comment #7)
> (In reply to Noam Rosenthal from comment #3)
> > (In reply to Tim Nguyen (:ntim) from comment #2)
> > > Comment on attachment 455749 [details]
> > > Patch
> > > 
> > > LGTM, but please address ios-wk2 failures before landing.
> > 
> > Thanks, will do
> > Probably a matter of adding fuzz meta, will look into it.
> 
> Can you export those changes to the WPT repo? Otherwise, they'll get lost at
> the next import.

Will do.
Btw css-masking had a lot of those that weren't previously exported, I'll export all of them.

[Noam Rosenthal]

(In reply to Noam Rosenthal from comment #8)
> (In reply to Tim Nguyen (:ntim) from comment #7)
> > (In reply to Noam Rosenthal from comment #3)
> > > (In reply to Tim Nguyen (:ntim) from comment #2)
> > > > Comment on attachment 455749 [details]
> > > > Patch
> > > > 
> > > > LGTM, but please address ios-wk2 failures before landing.
> > > 
> > > Thanks, will do
> > > Probably a matter of adding fuzz meta, will look into it.
> > 
> > Can you export those changes to the WPT repo? Otherwise, they'll get lost at
> > the next import.
> 
> Will do.

Done
https://github.com/web-platform-tests/wpt/pull/33378
Had to do this manually because the wpt-export script was barfing, I think it needs some love.

[Tim Nguyen (:ntim)]

(In reply to Noam Rosenthal from comment #9)
> (In reply to Noam Rosenthal from comment #8)
> > (In reply to Tim Nguyen (:ntim) from comment #7)
> > > (In reply to Noam Rosenthal from comment #3)
> > > > (In reply to Tim Nguyen (:ntim) from comment #2)
> > > > > Comment on attachment 455749 [details]
> > > > > Patch
> > > > > 
> > > > > LGTM, but please address ios-wk2 failures before landing.
> > > > 
> > > > Thanks, will do
> > > > Probably a matter of adding fuzz meta, will look into it.
> > > 
> > > Can you export those changes to the WPT repo? Otherwise, they'll get lost at
> > > the next import.
> > 
> > Will do.
> 
> Done
> https://github.com/web-platform-tests/wpt/pull/33378
> Had to do this manually because the wpt-export script was barfing, I think
> it needs some love.

Thanks! The files you edited in the PR unfortunately don't quite match the ones in the commit, see: https://bugs.webkit.org/attachment.cgi?oldid=455749&action=interdiff&newid=455837&headers=1 which I think is helpful.

[Noam Rosenthal]

(In reply to Tim Nguyen (:ntim) from comment #10)
> (In reply to Noam Rosenthal from comment #9)
> > (In reply to Noam Rosenthal from comment #8)
> > > (In reply to Tim Nguyen (:ntim) from comment #7)
> > > > (In reply to Noam Rosenthal from comment #3)
> > > > > (In reply to Tim Nguyen (:ntim) from comment #2)
> > > > > > Comment on attachment 455749 [details]
> > > > > > Patch
> > > > > > 
> > > > > > LGTM, but please address ios-wk2 failures before landing.
> > > > > 
> > > > > Thanks, will do
> > > > > Probably a matter of adding fuzz meta, will look into it.
> > > > 
> > > > Can you export those changes to the WPT repo? Otherwise, they'll get lost at
> > > > the next import.
> > > 
> > > Will do.
> > 
> > Done
> > https://github.com/web-platform-tests/wpt/pull/33378
> > Had to do this manually because the wpt-export script was barfing, I think
> > it needs some love.
> 
> Thanks! The files you edited in the PR unfortunately don't quite match the
> ones in the commit, see:
> https://bugs.webkit.org/attachment.
> cgi?oldid=455749&action=interdiff&newid=455837&headers=1 which I think is
> helpful.

Thanks, I was trying to use the export tool but it's not being helpful. A bit frustrated by this TBH but will try.