Bug 238371 – [CSS Shapes] Add support for shape()

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Noam Rosenthal]

See https://drafts.csswg.org/css-shapes-2/#shape-function

[Radar WebKit Bug Importer]

<rdar://problem/90919476>

[Noam Rosenthal]

Created attachment 457864 [details]
Patch

[EWS Watchlist]

This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess

[Noam Rosenthal]

Corresponding Chromium bug: https://bugs.chromium.org/p/chromium/issues/detail?id=1308431
Corresponding Mozilla bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1758784

[Noam Rosenthal]

Created attachment 457866 [details]
Patch

[Noam Rosenthal]

Created attachment 457867 [details]
Patch

[Noam Rosenthal]

Created attachment 457870 [details]
Patch

[Noam Rosenthal]

Created attachment 457874 [details]
Patch

[Noam Rosenthal]

Created attachment 457877 [details]
Patch

[Noam Rosenthal]

Created attachment 457881 [details]
Patch

[Noam Rosenthal]

Created attachment 457885 [details]
Patch

[Noam Rosenthal]

Created attachment 457889 [details]
Patch

[Noam Rosenthal]

Created attachment 457891 [details]
Patch

[Noam Rosenthal]

Created attachment 457901 [details]
Patch

[Noam Rosenthal]

Created attachment 457914 [details]
Patch

[Antoine Quint]

Hi Noam. Do you know whether there are existing animation tests for shape()? I don't see any new PASS results in the diff for tests that would improve. Do we need to import more? If so, I think it would be nice to import them first as failures, so this patch shows the progress. If not, then it would be GREAT for this patch to add animation testing coverage and upstream it to WPT.

[Noam Rosenthal]

(In reply to Antoine Quint from comment #16)
> Hi Noam. Do you know whether there are existing animation tests for shape()?
> I don't see any new PASS results in the diff for tests that would improve.
> Do we need to import more? If so, I think it would be nice to import them
> first as failures, so this patch shows the progress. If not, then it would
> be GREAT for this patch to add animation testing coverage and upstream it to
> WPT.

Yes of course, those tests are already upstreamed to WPT and imported to webkit, and this patch unskips them.

imported/w3c/web-platform-tests/css/css-masking/clip-path/clip-path-shape-interpolation-001.html
imported/w3c/web-platform-tests/css/css-masking/clip-path/clip-path-shape-interpolation-002.html

[Noam Rosenthal]

Created attachment 457962 [details]
Patch

[Noam Rosenthal]

Review anyone?

[Simon Fraser (smfr)]

https://github.com/w3c/csswg-drafts/issues/5841

[Noam Rosenthal]

(In reply to Simon Fraser (smfr) from comment #20)
> https://github.com/w3c/csswg-drafts/issues/5841

I believe these were addressed 2 years ago already, Tab added a lot regarding animation support for example.

[Noam Rosenthal]

Apologies, I see that only some of the comments (the animation related ones) were addressed and I missed the other ones. Will get back to the issue.

[Simon Fraser (smfr)]

Noam, do you mind if I take this over?

[Noam Rosenthal]

(In reply to Simon Fraser (smfr) from comment #23)
> Noam, do you mind if I take this over?

Please do, that would make me very happy! I suspect that my patch from 2 years ago is still mostly valid, and https://github.com/w3c/csswg-drafts/issues/5841 is still up and I think not far from a resolution. Hopefully if WebKit takes this on I can make the case for prioritizing this work in chrome as well.