Bug 237890 - [CSS Container Queries] Some more WPT updates
Summary: [CSS Container Queries] Some more WPT updates
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antti Koivisto
URL:
Keywords: InRadar
Depends on:
Blocks: 229659
  Show dependency tree / graph
 
Reported: 2022-03-15 06:53 PDT by Antti Koivisto
Modified: 2022-03-15 09:16 PDT (History)
5 users (show)

See Also:

Attachments
Patch (59.96 KB, patch)
2022-03-15 06:55 PDT, Antti Koivisto 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2022-03-15 06:53:42 PDT 
Some more WPT updates
Comment 1 Antti Koivisto 2022-03-15 06:55:32 PDT 
Created attachment 454703 [details]
Patch
Comment 2 Antoine Quint 2022-03-15 07:00:07 PDT 
Comment on attachment 454703 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454703&action=review

> LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/canvas-as-container-005.html:24
> +  setup(() => assert_implements_container_queries());

Wouldn't `setup(assert_implements_container_queries)` just work here?

> LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/display-none.html:367
> +    test(function() {

You can use `() =>`.
Comment 3 EWS 2022-03-15 09:15:06 PDT 
Committed r291293 (248432@main): <https://commits.webkit.org/248432@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 454703 [details].
Comment 4 Radar WebKit Bug Importer 2022-03-15 09:16:16 PDT 
<rdar://problem/90309391>