Bug 237882 – [WebGPU] Implement sampler creation according to the spec

• Status: RESOLVED
• Resolution: FIXED
• Component: WebGPU

[Myles C. Maxfield]

.

[Myles C. Maxfield]

Created attachment 454680 [details]
Patch

[Kimmo Kinnunen]

Comment on attachment 454680 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454680&action=review

> Source/WebGPU/WebGPU/Sampler.mm:40
> +    if (descriptor.lodMinClamp < 0)

an edge case of edge cases:
Do we have a mechanism to prevent NaNs in the floats or do we need to validate those?
(those cause tricky failures to debug even if it's a content issue, so if validation rejects those, maybe it'd be good use of time?)

[Kimmo Kinnunen]

Comment on attachment 454680 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454680&action=review

> Source/WebGPU/WebGPU/Sampler.mm:190
> +    samplerDescriptor.maxAnisotropy = descriptor.maxAnisotropy;

this should be clamped?

[Myles C. Maxfield]

Comment on attachment 454680 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454680&action=review

>> Source/WebGPU/WebGPU/Sampler.mm:40
>> +    if (descriptor.lodMinClamp < 0)
> 
> an edge case of edge cases:
> Do we have a mechanism to prevent NaNs in the floats or do we need to validate those?
> (those cause tricky failures to debug even if it's a content issue, so if validation rejects those, maybe it'd be good use of time?)

Yes, good catch. The spec says "Return true if and only if all of the following conditions are satisfied: descriptor.lodMinClamp is greater than or equal to 0. \ descriptor.lodMaxClamp is greater than or equal to descriptor.lodMinClamp." so I think a careful reading of the spec already catches NaN (those comparisons will be false in that case). My code, however, gets this wrong, since I've inverted the conditionals. I'll check for NaN explicitly.

>> Source/WebGPU/WebGPU/Sampler.mm:190
>> +    samplerDescriptor.maxAnisotropy = descriptor.maxAnisotropy;
> 
> this should be clamped?

Yes, the Metal spec https://developer.apple.com/documentation/metal/mtlsamplerdescriptor/1516164-maxanisotropy?language=objc says "Values must be between 1 and 16, inclusive."

[Myles C. Maxfield]

Committed r291387 (248518@trunk): <https://commits.webkit.org/248518@trunk>

[Radar WebKit Bug Importer]

<rdar://problem/90408334>