Bug 237879 - [WebGPU] Implement first draft of debug commands according to the spec
Summary: [WebGPU] Implement first draft of debug commands according to the spec
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGPU (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
Depends on: 237877
Blocks: 237882
  Show dependency tree / graph
 
Reported: 2022-03-15 00:21 PDT by Myles C. Maxfield
Modified: 2022-03-16 20:38 PDT (History)
4 users (show)

See Also:

Attachments
Patch (4.43 KB, patch)
2022-03-15 00:22 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (15.25 KB, patch)
2022-03-15 00:48 PDT, Myles C. Maxfield 		kkinnunen: review+
Details | Formatted Diff | Diff
Patch for committing (15.08 KB, patch)
2022-03-16 20:30 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2022-03-15 00:21:15 PDT 
.
Comment 1 Myles C. Maxfield 2022-03-15 00:22:51 PDT 
Created attachment 454673 [details]
Patch
Comment 2 Myles C. Maxfield 2022-03-15 00:48:13 PDT 
Created attachment 454675 [details]
Patch
Comment 3 Kimmo Kinnunen 2022-03-16 07:58:58 PDT 
Comment on attachment 454675 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454675&action=review

> Source/WebGPU/WebGPU/RenderPassEncoder.mm:112
> +    // There's no direct way of doing this, so we just push/pop an empty debug group.

is this comment still valid? below we seem to insert a signpost instead of an empty debug group
Comment 4 Myles C. Maxfield 2022-03-16 20:06:36 PDT 
Comment on attachment 454675 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454675&action=review

>> Source/WebGPU/WebGPU/RenderPassEncoder.mm:112
>> +    // There's no direct way of doing this, so we just push/pop an empty debug group.
> 
> is this comment still valid? below we seem to insert a signpost instead of an empty debug group

Nope! Good catch.
Comment 5 Myles C. Maxfield 2022-03-16 20:30:47 PDT 
Created attachment 454929 [details]
Patch for committing
Comment 6 Myles C. Maxfield 2022-03-16 20:37:24 PDT 
Committed r291386 (?): <https://commits.webkit.org/r291386>
Comment 7 Radar WebKit Bug Importer 2022-03-16 20:38:19 PDT 
<rdar://problem/90407762>