Bug 237657 - [CSS Container Queries] Implement new container selection algorithm
Summary: [CSS Container Queries] Implement new container selection algorithm
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antti Koivisto
URL:
Keywords: InRadar
Depends on:
Blocks: 229659
  Show dependency treegraph
 
Reported: 2022-03-09 07:54 PST by Antti Koivisto
Modified: 2022-03-10 18:16 PST (History)
8 users (show)

See Also:


Attachments
Patch (23.70 KB, patch)
2022-03-09 08:35 PST, Antti Koivisto
ews-feeder: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2022-03-09 07:54:40 PST
https://github.com/w3c/csswg-drafts/issues/6644
Comment 1 Antti Koivisto 2022-03-09 08:35:26 PST
Created attachment 454243 [details]
Patch
Comment 2 Antoine Quint 2022-03-10 01:31:52 PST
Comment on attachment 454243 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454243&action=review

> Source/WebCore/css/ContainerQueryParser.cpp:41
> +    auto consumeName = [&]() -> AtomString {

I never know just by glancing at the code, but have you tried leaving out the explicit return type?

> Source/WebCore/css/ContainerQueryParser.cpp:50
> +    auto name = consumeName();

My personal preference is to call the lambda directly and not assign it an intermediate value.
Comment 3 Antti Koivisto 2022-03-10 01:38:14 PST
> I never know just by glancing at the code, but have you tried leaving out
> the explicit return type?

doesn't work here without other changes because stringValue() is not AtomicString
Comment 4 EWS 2022-03-10 02:23:30 PST
Committed r291098 (248260@main): <https://commits.webkit.org/248260@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 454243 [details].
Comment 5 Radar WebKit Bug Importer 2022-03-10 02:24:16 PST
<rdar://problem/90087903>