Bug 237527 - [GTK][WPE] Add initial adwaita style for PDF.js
Summary: [GTK][WPE] Add initial adwaita style for PDF.js
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on: 237516
Blocks:
  Show dependency treegraph
 
Reported: 2022-03-07 06:31 PST by Carlos Garcia Campos
Modified: 2022-03-10 05:28 PST (History)
2 users (show)

See Also:


Attachments
Patch (4.44 KB, patch)
2022-03-07 06:33 PST, Carlos Garcia Campos
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2022-03-07 06:31:43 PST
Initial adwaita style.
Comment 1 Carlos Garcia Campos 2022-03-07 06:33:26 PST
Created attachment 453972 [details]
Patch

This won't apply as it's based on bug #237516
Comment 2 Michael Catanzaro 2022-03-07 07:50:43 PST
Comment on attachment 453972 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=453972&action=review

> Source/WebCore/Modules/pdfjs-extras/adwaita/style.css:27
> +#openFile {
> +    display: none !important;
> +}

Is the file chooser not working?

> Source/WebCore/Modules/pdfjs-extras/adwaita/style.css:31
> +.dropdownToolbarButton > select {
> +    -webkit-appearance: none;
> +}

Hm, honestly I don't remember exactly what this hack was used for, other than to hide something that was broken in Epiphany. Jan-Michael might remember for sure.
Comment 3 Carlos Garcia Campos 2022-03-08 00:39:39 PST
Comment on attachment 453972 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=453972&action=review

>> Source/WebCore/Modules/pdfjs-extras/adwaita/style.css:27
>> +}
> 
> Is the file chooser not working?

Yes, opening files results in an error message. I don't know why, but I'm not sure we want to provide that functionality either.

>> Source/WebCore/Modules/pdfjs-extras/adwaita/style.css:31
>> +}
> 
> Hm, honestly I don't remember exactly what this hack was used for, other than to hide something that was broken in Epiphany. Jan-Michael might remember for sure.

This is not hiding anything, this is telling WebKit not to use the native appearance for the zoom combo box in the toolbar, because the adwaita one is bigger and doesn't look right. Hopefully Alexander can add customizations here to make it look great and consistent with adwaita.
Comment 4 Carlos Garcia Campos 2022-03-10 01:30:52 PST
Committed r291096 (248258@trunk): <https://commits.webkit.org/248258@trunk>