Bug 237516 – PDF.js content script is adding custom cocoa style unconditionally

• Status: RESOLVED
• Resolution: FIXED
• Component: PDF

[Carlos Garcia Campos]

I should be possible to add different style depending on the platform.

[Carlos Garcia Campos]

Created attachment 453953 [details]
Patch

[Tim Nguyen (:ntim)]

Comment on attachment 453953 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=453953&action=review

> Source/WebCore/html/PDFDocument.cpp:217
> +#if PLATFORM(COCOA)
> +    link->setAttribute(hrefAttr, "webkit-pdfjs-viewer://pdfjs/extras/cocoa/style.css"_s);
> +#endif

Do #if preprocessing conditions not work in the JS file? If they do, I'd rather see this logic in the JS file.

[Carlos Garcia Campos]

Comment on attachment 453953 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=453953&action=review

>> Source/WebCore/html/PDFDocument.cpp:217
>> +#endif
> 
> Do #if preprocessing conditions not work in the JS file? If they do, I'd rather see this logic in the JS file.

I don't think so, the script is injected as is, without any preprocessing. I don't know how to make it platform dependent in a JS file, that's why I moved it to cpp.

[EWS]

Committed r290983 (248161@main): <https://commits.webkit.org/248161@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 453953 [details].

[Radar WebKit Bug Importer]

<rdar://problem/89955906>