Bug 237276 - REGRESSION(r285232) https://alvaromontoro.github.io/almond.css/demo/ looks wrong in Safari, ok in Chrome and Firefox
Summary: REGRESSION(r285232) https://alvaromontoro.github.io/almond.css/demo/ looks wr...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: BrowserCompat, InRadar
: 240278 (view as bug list)
Depends on:
Blocks:
 
Reported: 2022-02-28 09:19 PST by Jon Lee
Modified: 2022-05-26 14:52 PDT (History)
17 users (show)

See Also:

Attachments
Test reduction (230 bytes, text/html)
2022-03-01 08:48 PST, zalan 		no flags Details
Patch (4.70 KB, patch)
2022-03-01 13:37 PST, zalan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jon Lee 2022-02-28 09:19:02 PST 
https://alvaromontoro.github.io/almond.css/demo/

Scroll to the bottom of the page. There are circular progress bars. The percentage label is misplaced in Safari, it is properly centered in Chrome and Firefox.
Comment 1 Simon Fraser (smfr) 2022-02-28 09:50:47 PST 
This is grid with `place-items: center`.
Comment 2 Radar WebKit Bug Importer 2022-02-28 10:11:32 PST 
<rdar://problem/89566459>
Comment 3 zalan 2022-03-01 08:48:09 PST 
Created attachment 453500 [details]
Test reduction
Comment 4 zalan 2022-03-01 13:37:58 PST 
Created attachment 453537 [details]
Patch
Comment 5 Simon Fraser (smfr) 2022-03-01 13:41:26 PST 
Comment on attachment 453537 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=453537&action=review

> LayoutTests/ChangeLog:10
> +        * fast/css-grid-layout/ascpect-ratio-with-percent-width-expected.html: Added.
> +        * fast/css-grid-layout/ascpect-ratio-with-percent-width.html: Added.

Ideally this would be a WPT
Comment 6 EWS 2022-03-01 16:01:09 PST 
Committed r290706 (247955@main): <https://commits.webkit.org/247955@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 453537 [details].
Comment 7 Frédéric Wang (:fredw) 2022-03-02 00:26:05 PST 
Comment on attachment 453537 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=453537&action=review

>> LayoutTests/ChangeLog:10
>> +        * fast/css-grid-layout/ascpect-ratio-with-percent-width.html: Added.
> 
> Ideally this would be a WPT

Any reason, why this was not converted to a WPT reftest in the committed patch?

nit: there is a typo in the file name, it should be "aspect".
Comment 8 Sam Sneddon [:gsnedders] 2022-05-10 09:55:38 PDT 
*** Bug 240278 has been marked as a duplicate of this bug. ***
Comment 9 Brent Fulgham 2022-05-26 14:52:59 PDT 
This fix shipped with Safari 15.5 (all platforms).