Bug 237085 – Share more code between service and shared workers for context connection establishment

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Chris Dumez]

Share more code between service and shared workers for context connection establishment.

[Chris Dumez]

Created attachment 452981 [details]
Patch

[youenn fablet]

Comment on attachment 452981 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452981&action=review

> Source/WebKit/UIProcess/Network/NetworkProcessProxy.messages.in:59
> +    EstablishRemoteWorkerContextConnectionToNetworkProcess(enum:uint32_t WebKit::RemoteWorkerType workerType, WebCore::RegistrableDomain registrableDomain, std::optional<WebCore::ProcessIdentifier> requestingProcessIdentifier, std::optional<WebCore::ScriptExecutionContextIdentifier> serviceWorkerPageIdentifier, PAL::SessionID sessionID) -> () Async

Why is it a uint32_t, should it not be either a bool or maybe a uint8_t?

> Source/WebKit/UIProcess/WebProcessPool.cpp:558
> +    bool shouldUseSeparateRemoteWorkerProcess = workerType == RemoteWorkerType::ServiceWorker && s_useSeparateServiceWorkerProcess;

We might want to use s_useSeparateServiceWorkerProcess for shared workers as well for testing things like crash of shared worker process.

[Chris Dumez]

Created attachment 452985 [details]
Patch

[Chris Dumez]

Created attachment 452986 [details]
Patch

[Chris Dumez]

Created attachment 452994 [details]
Patch

[EWS]

Committed r290387 (247702@main): <https://commits.webkit.org/247702@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 452994 [details].

[Radar WebKit Bug Importer]

<rdar://problem/89370920>