Bug 236874 – http/wpt/push-api/onpush-disabled.html fails

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Ryan Haddad]

http/wpt/push-api/onpush-disabled.html is failing on bots, but may be related to an issue with incremental builds & the IDL file change when it was added with https://trac.webkit.org/changeset/290156/webkit

--- /Volumes/Data/worker/bigsur-release-applesilicon-tests-wk2/build/layout-test-results/http/wpt/push-api/onpush-disabled-expected.txt
+++ /Volumes/Data/worker/bigsur-release-applesilicon-tests-wk2/build/layout-test-results/http/wpt/push-api/onpush-disabled-actual.txt
@@ -1,4 +1,4 @@
 
-PASS onpush should not be exposed on ServiceWorkerGlobalScope
-PASS onpushsubscriptionchange should not be exposed on ServiceWorkerGlobalScope
+FAIL onpush should not be exposed on ServiceWorkerGlobalScope assert_false: expected false got true
+FAIL onpushsubscriptionchange should not be exposed on ServiceWorkerGlobalScope assert_false: expected false got true
 

https://results.webkit.org/?suite=layout-tests&test=http%2Fwpt%2Fpush-api%2Fonpush-disabled.html

[Radar WebKit Bug Importer]

<rdar://problem/89176154>

[Ryan Haddad]

Well, I triggered a clean build on a trunk bot and it appears that the test still fails: https://build.webkit.org/#/builders/104/builds/6665

[Ryan Haddad]

Marked test as failing in r290192 to help EWS.

[Chris Dumez]

Ok, it appears I can reproduce if I run the whole http/wpt folder. I am investigating.

[Chris Dumez]

Created attachment 452910 [details]
Patch

[EWS]

Committed r290352 (247670@main): <https://commits.webkit.org/247670@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 452910 [details].

[Patrick Angle]

*** Bug 240705 has been marked as a duplicate of this bug. ***