Bug 237079 – [CSS Container Queries] offsetWidth/Height and similar should update layout for container queries

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Antti Koivisto]

css/css-contain/container-queries/inline-size-containment.html
css/css-contain/container-queries/inline-size-containment-vertical-rl.html

[Antti Koivisto]

Created attachment 452966 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 452966 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452966&action=review

> Source/WebCore/dom/Document.cpp:2218
> +    while (styleScope().updateQueryContainerState(queryContainerUpdateContext)) {
> +        updateStyleIfNeeded();
> +
> +        if (!frameView->layoutContext().needsLayout())
> +            break;
> +
> +        frameView->layoutContext().layout();

This makes me nervous that we could get into an infinite loop here. Should we bail after N iterations?

[Antti Koivisto]

> This makes me nervous that we could get into an infinite loop here. Should
> we bail after N iterations?

The queryContainerUpdateContext thing does prevent infinite looping (since in worst case you'll eventually have every element in that set and won't invalidate anything any more).

[EWS]

Committed r290380 (247695@main): <https://commits.webkit.org/247695@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 452966 [details].

[Radar WebKit Bug Importer]

<rdar://problem/89363521>