[WASM-GC] WIP: introduce structs
Created attachment 452850 [details] Patch
This patch modifies one of the wasm.json files. Please ensure that any changes in one have been mirrored to the other. You can find the wasm.json files at "Source/JavaScriptCore/wasm/wasm.json" and "JSTests/wasm/wasm.json".
<rdar://problem/89611482>
Comment on attachment 452850 [details] Patch This approach looks good to me. Not sure if you meant to set r?
I've set the r?
Comment on attachment 452850 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=452850&action=review r=me, should we rename the Signature class to something else. I worry that we’re somewhat misusing that term from classical its classical meaning. > Source/JavaScriptCore/wasm/WasmLimits.h:47 > +constexpr size_t maxStructFieldCount = 1000000; That’s a huge number, can we handle things that large? Is that the spec limit? > Source/JavaScriptCore/wasm/WasmSectionParser.cpp:61 > + return fail(i, "th struct types are not enabled"); Nit: Maybe “th type failed to parse…”, or does ‘fail’ say what section we are in?
Created attachment 456130 [details] Patch
Reduced maxStructFieldCount, it is not a spec limit so imho 10000 is enough. Also fixed the error message for section parser.
Created attachment 456328 [details] Patch
Created attachment 456503 [details] Patch
Created attachment 456905 [details] Patch
Committed r292773 (249557@main): <https://commits.webkit.org/249557@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 456905 [details].