RESOLVED FIXED 23700
Upstream local changes to GlyphPageTreeNodeChromiumWin.cpp 
https://bugs.webkit.org/show_bug.cgi?id=23700
Summary Upstream local changes to GlyphPageTreeNodeChromiumWin.cpp
Dimitri Glazkov (Google)
Reported 2009-02-02 20:38:03 PST
The change in fillBMPGlyphs is due to unforking of SimpleFontData and the change in fillNonBMPGlyphs is to address http://code.google.com/p/chromium/issues/detail?id=6303
Attachments
Upstream local changes to due to unforking, bug fixes. (2.71 KB, patch)
2009-02-02 20:40 PST, Dimitri Glazkov (Google) 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dimitri Glazkov (Google)
Comment 1 2009-02-02 20:40:35 PST
Created attachment 27274 [details] Upstream local changes to due to unforking, bug fixes. WebCore/ChangeLog | 11 +++++++++++ .../chromium/GlyphPageTreeNodeChromiumWin.cpp | 15 +++------------ 2 files changed, 14 insertions(+), 12 deletions(-)
Eric Seidel (no email)
Comment 2 2009-02-02 23:35:30 PST
Comment on attachment 27274 [details] Upstream local changes to due to unforking, bug fixes. It would be useful to know what these changes are for? Otherwise the change looks fine... if you update the ChangeLog to point to the chromium bugs fixed (or at least the commits) that would be helpful.
Darin Adler
Comment 3 2009-02-03 09:28:32 PST
Comment on attachment 27274 [details] Upstream local changes to due to unforking, bug fixes. rs=me
Jungshik Shin
Comment 4 2009-02-03 11:17:01 PST
Dimitiri, this patch overlaps with what I put up for bug 23602. setDisableFontFallback bit relies on that patch. Can you remove that part from the patch here or merge two patches (for bug 23602 and this bug)? Eric, can you review the patch for bug 23602?
Dimitri Glazkov (Google)
Comment 5 2009-02-03 11:38:13 PST
Oops -- I will remove your modification, Jungshik. Didn't mean to step on your toes.
Dimitri Glazkov (Google)
Comment 6 2009-02-04 11:07:55 PST
Landed as http://trac.webkit.org/changeset/40619
Note You need to log in before you can comment on or make changes to this bug.