Bug 23602 - add another piece (left out earlier) in platform/graphics/chromium
Summary: add another piece (left out earlier) in platform/graphics/chromium
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P2 Enhancement
Assignee: Jungshik Shin
Depends on:
Reported: 2009-01-28 14:26 PST by Jungshik Shin
Modified: 2009-02-04 15:23 PST (History)
1 user (show)

See Also:

patch (5.43 KB, patch)
2009-01-28 14:45 PST, Jungshik Shin
eric: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jungshik Shin 2009-01-28 14:26:44 PST
This is what's left out in the patch for bug 23340 (I should have made certain that this was landed as a part of the patch, but due to a 'bad timing', this piece missed the train). 

This patch is for non-BMP characters in Chromium-Win.
Comment 1 Jungshik Shin 2009-01-28 14:45:07 PST
Created attachment 27125 [details]

Recap from ChangeLog (FYI):
        This comes from Chromium patch (http://codereview.chromium.org/17624).

        Add m_disableFontFallback to UniscriberHelper class and set it
        to true when filling up glyph pages for non-BMP code points.
        When it's set true, UniscriberHelper does not do its own font
        fallback. Neither does it do glyph placement. Font fallback
        will be taken care of in the simple script font path and glyph
        placement is not necessary for simple scripts.

        Layout test is missing at the moment due to the lack of freely
        distributable font covering a non-BMP code page. A test page
        is available at http://i18nl10n.com/webkit/nonbmp2.html

As for the layout test, I plan to make a simple TTF with 'ugly' glyphs covering a small number of non-BMP characters.
Comment 2 Eric Seidel (no email) 2009-02-03 14:57:14 PST
Comment on attachment 27125 [details]

This looks fine.  I'll land after fixing the spacing on one indent.
Comment 3 Eric Seidel (no email) 2009-02-04 15:16:50 PST
Sigh.  It looks like this patch file was modified after it was created. :(  That's bad, cause it means it won't apply.  I fixed up the ChangeLog section of the patch to apply, looks like a line was removed from the ChangeLog portion of the patchfile instead of removing the line first from the ChangeLog and regenerating the patch file.
Comment 4 Eric Seidel (no email) 2009-02-04 15:23:24 PST
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/platform/graphics/chromium/GlyphPageTreeNodeChromiumWin.cpp
	M	WebCore/platform/graphics/chromium/UniscribeHelper.cpp
	M	WebCore/platform/graphics/chromium/UniscribeHelper.h
Committed r40635