Bug 236846 – onpush/onpushsubscriptionchange exposed in Service Workers when Push API is disabled

• Status: RESOLVED
• Resolution: FIXED
• Component: Service Workers

[Sam Sneddon [:gsnedders]]

This will be because:

[
    EnabledAtRuntime=ServiceWorkerEnabled
] partial interface ServiceWorkerGlobalScope {
    attribute EventHandler onpush;
    attribute EventHandler onpushsubscriptionchange;
};

This isn't gated on Push API being enabled.

[Radar WebKit Bug Importer]

<rdar://problem/89154452>

[Sam Sneddon [:gsnedders]]

Created attachment 452554 [details]
Patch

[Tim Nguyen (:ntim)]

Comment on attachment 452554 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452554&action=review

> LayoutTests/http/wpt/push-api/onpush-disabled-expected.txt:3
> +PASS onpush
> +PASS onpushsubscriptionchange

Can you use more descriptive PASS messages like "onpush is not exposed when pref is disabled"?

> LayoutTests/http/wpt/push-api/onpush-enabled-expected.txt:3
> +PASS onpush
> +PASS onpushsubscriptionchange

ditto

[Chris Dumez]

Comment on attachment 452554 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452554&action=review

> Source/WebCore/Modules/push-api/ServiceWorkerGlobalScope+PushAPI.idl:28
> +    EnabledAtRuntime=PushAPIEnabled

Shouldn't this be `EnabledAtRuntime=ServiceWorkerEnabled&PushAPIEnabled` ?

[Chris Dumez]

Created attachment 452556 [details]
[fast-cq] Patch

[Chris Dumez]

Comment on attachment 452556 [details]
[fast-cq] Patch

Clearing flags on attachment: 452556

Committed r290156 (247495@trunk): <https://commits.webkit.org/247495@trunk>

[Chris Dumez]

All reviewed patches have been landed.  Closing bug.