WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
236840
[CSS Container Queries] Match container queries correctly in non-rendered subtrees
https://bugs.webkit.org/show_bug.cgi?id=236840
Summary
[CSS Container Queries] Match container queries correctly in non-rendered sub...
Antti Koivisto
Reported
2022-02-18 07:53:13 PST
"If the query container does not have a principal box ... then the result of evaluating the size feature is unknown."
https://drafts.csswg.org/css-contain-3/#size-container
Attachments
Patch
(25.65 KB, patch)
2022-02-18 08:04 PST
,
Antti Koivisto
no flags
Details
Formatted Diff
Diff
Patch for landing
(25.71 KB, patch)
2022-02-18 09:06 PST
,
Antti Koivisto
no flags
Details
Formatted Diff
Diff
Patch for landing
(26.42 KB, patch)
2022-02-18 10:49 PST
,
Antti Koivisto
no flags
Details
Formatted Diff
Diff
Patch for landing
(26.44 KB, patch)
2022-02-18 22:17 PST
,
Antti Koivisto
no flags
Details
Formatted Diff
Diff
Patch
(25.73 KB, patch)
2022-02-18 22:47 PST
,
Antti Koivisto
ews-feeder
: commit-queue-
Details
Formatted Diff
Diff
Show Obsolete
(4)
View All
Add attachment
proposed patch, testcase, etc.
Antti Koivisto
Comment 1
2022-02-18 08:04:42 PST
Created
attachment 452521
[details]
Patch
Dean Jackson
Comment 2
2022-02-18 08:47:50 PST
Comment on
attachment 452521
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=452521&action=review
> Source/WebCore/style/ContainerQueryEvaluator.cpp:180 > + // If the query container does not have a principal box ... then the result of evaluating the size feature is unknown."
Nit: Either missing a leading " or maybe give the spec URL?
Antti Koivisto
Comment 3
2022-02-18 09:06:00 PST
Created
attachment 452525
[details]
Patch for landing
Antti Koivisto
Comment 4
2022-02-18 10:49:40 PST
Created
attachment 452543
[details]
Patch for landing
EWS
Comment 5
2022-02-18 13:21:16 PST
Patch 452543 does not build
Antti Koivisto
Comment 6
2022-02-18 22:17:47 PST
Created
attachment 452627
[details]
Patch for landing
Antti Koivisto
Comment 7
2022-02-18 22:47:21 PST
Created
attachment 452629
[details]
Patch
EWS
Comment 8
2022-02-19 06:07:08 PST
Committed
r290205
(
247533@main
): <
https://commits.webkit.org/247533@main
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 452629
[details]
.
Radar WebKit Bug Importer
Comment 9
2022-02-19 06:08:16 PST
<
rdar://problem/89186400
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug