Bug 236840 - [CSS Container Queries] Match container queries correctly in non-rendered subtrees
Summary: [CSS Container Queries] Match container queries correctly in non-rendered sub...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antti Koivisto
URL:
Keywords: InRadar
Depends on:
Blocks: 229659
  Show dependency tree / graph
 
Reported: 2022-02-18 07:53 PST by Antti Koivisto
Modified: 2022-02-19 09:21 PST (History)
8 users (show)

See Also:

Attachments
Patch (25.65 KB, patch)
2022-02-18 08:04 PST, Antti Koivisto 		no flags Details | Formatted Diff | Diff
Patch for landing (25.71 KB, patch)
2022-02-18 09:06 PST, Antti Koivisto 		no flags Details | Formatted Diff | Diff
Patch for landing (26.42 KB, patch)
2022-02-18 10:49 PST, Antti Koivisto 		no flags Details | Formatted Diff | Diff
Patch for landing (26.44 KB, patch)
2022-02-18 22:17 PST, Antti Koivisto 		no flags Details | Formatted Diff | Diff
Patch (25.73 KB, patch)
2022-02-18 22:47 PST, Antti Koivisto 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2022-02-18 07:53:13 PST 
"If the query container does not have a principal box ... then the result of evaluating the size feature is unknown."

https://drafts.csswg.org/css-contain-3/#size-container
Comment 1 Antti Koivisto 2022-02-18 08:04:42 PST 
Created attachment 452521 [details]
Patch
Comment 2 Dean Jackson 2022-02-18 08:47:50 PST 
Comment on attachment 452521 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452521&action=review

> Source/WebCore/style/ContainerQueryEvaluator.cpp:180
> +    // If the query container does not have a principal box ... then the result of evaluating the size feature is unknown."

Nit: Either missing a leading " or maybe give the spec URL?
Comment 3 Antti Koivisto 2022-02-18 09:06:00 PST 
Created attachment 452525 [details]
Patch for landing
Comment 4 Antti Koivisto 2022-02-18 10:49:40 PST 
Created attachment 452543 [details]
Patch for landing
Comment 5 EWS 2022-02-18 13:21:16 PST 
Patch 452543 does not build
Comment 6 Antti Koivisto 2022-02-18 22:17:47 PST 
Created attachment 452627 [details]
Patch for landing
Comment 7 Antti Koivisto 2022-02-18 22:47:21 PST 
Created attachment 452629 [details]
Patch
Comment 8 EWS 2022-02-19 06:07:08 PST 
Committed r290205 (247533@main): <https://commits.webkit.org/247533@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 452629 [details].
Comment 9 Radar WebKit Bug Importer 2022-02-19 06:08:16 PST 
<rdar://problem/89186400>