Bug 236771 - [CSS Container Queries] Support full range notation in size queries
Summary: [CSS Container Queries] Support full range notation in size queries
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antti Koivisto
URL:
Keywords: InRadar
Depends on:
Blocks: 229659
  Show dependency treegraph
 
Reported: 2022-02-17 04:28 PST by Antti Koivisto
Modified: 2022-02-17 11:40 PST (History)
8 users (show)

See Also:


Attachments
Patch (22.70 KB, patch)
2022-02-17 05:04 PST, Antti Koivisto
no flags Details | Formatted Diff | Diff
Patch for landing (22.69 KB, patch)
2022-02-17 08:12 PST, Antti Koivisto
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2022-02-17 04:28:50 PST
(100px < width) and (100px < width < 200px)
Comment 1 Antti Koivisto 2022-02-17 05:04:41 PST
Created attachment 452353 [details]
Patch
Comment 2 Dean Jackson 2022-02-17 07:58:31 PST
Comment on attachment 452353 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452353&action=review

> Source/WebCore/style/ContainerQueryEvaluator.cpp:195
> +    auto evaluateAspectRatioComparison = [&](double aspectRation, const std::optional<CQ::Comparison>& comparison, Side side) {

Typo: aspectRation
Comment 3 Antti Koivisto 2022-02-17 08:12:42 PST
Created attachment 452369 [details]
Patch for landing
Comment 4 EWS 2022-02-17 11:39:23 PST
Committed r290037 (247415@main): <https://commits.webkit.org/247415@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 452369 [details].
Comment 5 Radar WebKit Bug Importer 2022-02-17 11:40:18 PST
<rdar://problem/89099831>