Bug 236745 - [MacCatalyst] improve support for resizing
Summary: [MacCatalyst] improve support for resizing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks: 237126 240691
  Show dependency tree / graph
 
Reported: 2022-02-16 17:31 PST by Devin Rousso
Modified: 2022-05-19 16:17 PDT (History)
8 users (show)

See Also:

Attachments
Patch (9.20 KB, patch)
2022-02-16 17:56 PST, Devin Rousso 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2022-02-16 17:31:27 PST 
.
Comment 1 Devin Rousso 2022-02-16 17:31:49 PST 
<rdar://problem/86494393>
Comment 2 Devin Rousso 2022-02-16 17:56:37 PST 
Created attachment 452281 [details]
Patch
Comment 3 EWS 2022-02-17 16:43:33 PST 
Committed r290091 (247445@main): <https://commits.webkit.org/247445@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 452281 [details].
Comment 4 Wenson Hsieh 2022-05-19 16:14:08 PDT 
Comment on attachment 452281 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452281&action=review

> Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm:2013
> +    _resizeAssertions.append(adoptNS([windowScene _holdLiveResizeSnapshotForReason:reason]));

This `adoptNS` looks suspicious.
Comment 5 Devin Rousso 2022-05-19 16:16:10 PDT 
Comment on attachment 452281 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452281&action=review

>> Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm:2013
>> +    _resizeAssertions.append(adoptNS([windowScene _holdLiveResizeSnapshotForReason:reason]));
> 
> This `adoptNS` looks suspicious.

this was changed in r290442
Comment 6 Wenson Hsieh 2022-05-19 16:17:26 PDT 
(In reply to Devin Rousso from comment #5)
> Comment on attachment 452281 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=452281&action=review
> 
> >> Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm:2013
> >> +    _resizeAssertions.append(adoptNS([windowScene _holdLiveResizeSnapshotForReason:reason]));
> > 
> > This `adoptNS` looks suspicious.
> 
> this was changed in r290442

🤦🏻‍♂️ I didn't look at the date of the patch, and thought it was just uploaded.