Bug 236717 – Resync web-platform-tests/paint-timing from upstream

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Noam Rosenthal]

Resync web-platform-tests/paint-timing from upstream

[Noam Rosenthal]

Created attachment 452210 [details]
Patch

[EWS Watchlist]

This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess

[Noam Rosenthal]

Created attachment 452211 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 452211 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452211&action=review

> LayoutTests/imported/w3c/web-platform-tests/paint-timing/fcp-only/fcp-background-size.html:21
> +<script src="../../../../../resources/testharness.js"></script>
> +<script src="../../../../../resources/testharnessreport.js"></script>

These don't seem right. Did you use the script to import? The tests are run via the http server so no need to fix up paths.

[Noam Rosenthal]

(In reply to Simon Fraser (smfr) from comment #4)
> Comment on attachment 452211 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=452211&action=review
> 
> > LayoutTests/imported/w3c/web-platform-tests/paint-timing/fcp-only/fcp-background-size.html:21
> > +<script src="../../../../../resources/testharness.js"></script>
> > +<script src="../../../../../resources/testharnessreport.js"></script>
> 
> These don't seem right. Did you use the script to import? The tests are run
> via the http server so no need to fix up paths.

Sure used the script, maybe wrong args. Will try again

[Noam Rosenthal]

Created attachment 452326 [details]
Patch

[Noam Rosenthal]

(In reply to Noam Rosenthal from comment #5)
> (In reply to Simon Fraser (smfr) from comment #4)
> > Comment on attachment 452211 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=452211&action=review
> > 
> > > LayoutTests/imported/w3c/web-platform-tests/paint-timing/fcp-only/fcp-background-size.html:21
> > > +<script src="../../../../../resources/testharness.js"></script>
> > > +<script src="../../../../../resources/testharnessreport.js"></script>
> > 
> > These don't seem right. Did you use the script to import? The tests are run
> > via the http server so no need to fix up paths.
> 
> Sure used the script, maybe wrong args. Will try again

Forgot the "-l" when importing from local folder. Should be good now

[Noam Rosenthal]

Created attachment 452331 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 452331 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452331&action=review

> LayoutTests/imported/w3c/ChangeLog:7
> +        Resync web-platform-tests/paint-timing from upstream
> +        https://bugs.webkit.org/show_bug.cgi?id=236717
> +
> +        Reviewed by NOBODY (OOPS!).
> +

Double changlelog (I prefer the first one with the wpt git hash).

[Noam Rosenthal]

Created attachment 452381 [details]
Patch

[EWS]

Committed r290080 (247436@main): <https://commits.webkit.org/247436@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 452381 [details].

[Radar WebKit Bug Importer]

<rdar://problem/89111485>