Bug 236717 - Resync web-platform-tests/paint-timing from upstream
Summary: Resync web-platform-tests/paint-timing from upstream
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Noam Rosenthal
URL:
Keywords: InRadar
Depends on:
Blocks: 225305
  Show dependency tree / graph
 
Reported: 2022-02-16 10:38 PST by Noam Rosenthal
Modified: 2022-02-17 15:15 PST (History)
10 users (show)

See Also:

Attachments
Patch (55.94 KB, patch)
2022-02-16 10:38 PST, Noam Rosenthal 		no flags Details | Formatted Diff | Diff
Patch (61.38 KB, patch)
2022-02-16 10:42 PST, Noam Rosenthal 		no flags Details | Formatted Diff | Diff
Patch (46.99 KB, patch)
2022-02-16 23:31 PST, Noam Rosenthal 		no flags Details | Formatted Diff | Diff
Patch (53.57 KB, patch)
2022-02-16 23:55 PST, Noam Rosenthal 		no flags Details | Formatted Diff | Diff
Patch (49.20 KB, patch)
2022-02-17 10:05 PST, Noam Rosenthal 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Noam Rosenthal 2022-02-16 10:38:26 PST 
Resync web-platform-tests/paint-timing from upstream
Comment 1 Noam Rosenthal 2022-02-16 10:38:41 PST 
Created attachment 452210 [details]
Patch
Comment 2 EWS Watchlist 2022-02-16 10:40:03 PST 
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess
Comment 3 Noam Rosenthal 2022-02-16 10:42:50 PST 
Created attachment 452211 [details]
Patch
Comment 4 Simon Fraser (smfr) 2022-02-16 11:03:24 PST 
Comment on attachment 452211 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452211&action=review

> LayoutTests/imported/w3c/web-platform-tests/paint-timing/fcp-only/fcp-background-size.html:21
> +<script src="../../../../../resources/testharness.js"></script>
> +<script src="../../../../../resources/testharnessreport.js"></script>

These don't seem right. Did you use the script to import? The tests are run via the http server so no need to fix up paths.
Comment 5 Noam Rosenthal 2022-02-16 12:02:34 PST 
(In reply to Simon Fraser (smfr) from comment #4)
> Comment on attachment 452211 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=452211&action=review
> 
> > LayoutTests/imported/w3c/web-platform-tests/paint-timing/fcp-only/fcp-background-size.html:21
> > +<script src="../../../../../resources/testharness.js"></script>
> > +<script src="../../../../../resources/testharnessreport.js"></script>
> 
> These don't seem right. Did you use the script to import? The tests are run
> via the http server so no need to fix up paths.

Sure used the script, maybe wrong args. Will try again
Comment 6 Noam Rosenthal 2022-02-16 23:31:37 PST 
Created attachment 452326 [details]
Patch
Comment 7 Noam Rosenthal 2022-02-16 23:33:19 PST 
(In reply to Noam Rosenthal from comment #5)
> (In reply to Simon Fraser (smfr) from comment #4)
> > Comment on attachment 452211 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=452211&action=review
> > 
> > > LayoutTests/imported/w3c/web-platform-tests/paint-timing/fcp-only/fcp-background-size.html:21
> > > +<script src="../../../../../resources/testharness.js"></script>
> > > +<script src="../../../../../resources/testharnessreport.js"></script>
> > 
> > These don't seem right. Did you use the script to import? The tests are run
> > via the http server so no need to fix up paths.
> 
> Sure used the script, maybe wrong args. Will try again

Forgot the "-l" when importing from local folder. Should be good now
Comment 8 Noam Rosenthal 2022-02-16 23:55:11 PST 
Created attachment 452331 [details]
Patch
Comment 9 Simon Fraser (smfr) 2022-02-17 09:28:16 PST 
Comment on attachment 452331 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452331&action=review

> LayoutTests/imported/w3c/ChangeLog:7
> +        Resync web-platform-tests/paint-timing from upstream
> +        https://bugs.webkit.org/show_bug.cgi?id=236717
> +
> +        Reviewed by NOBODY (OOPS!).
> +

Double changlelog (I prefer the first one with the wpt git hash).
Comment 10 Noam Rosenthal 2022-02-17 10:05:43 PST 
Created attachment 452381 [details]
Patch
Comment 11 EWS 2022-02-17 15:14:37 PST 
Committed r290080 (247436@main): <https://commits.webkit.org/247436@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 452381 [details].
Comment 12 Radar WebKit Bug Importer 2022-02-17 15:15:18 PST 
<rdar://problem/89111485>