Bug 225305 – PerformanceObserver: buffered flag not working in Paint Timing

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Nicolas]

The PerformanceObserver's buffered flag is implemented and works in, for instance, Resource Timing. But it does not seem to work in Paint Timing.

Test: go to any website, let it load, then run this on the console:
new PerformanceObserver((l)=>console.log(l.getEntries())).observe({type:'paint', buffered: true})

It is expected to show the Paint Timing entry, but it does not work.

See https://github.com/GoogleChrome/web-vitals/pull/139 for more info.

[Radar WebKit Bug Importer]

<rdar://problem/77746237>

[Noam Rosenthal]

*** Bug 236155 has been marked as a duplicate of this bug. ***

[Noam Rosenthal]

Failing test: https://wpt.fyi/results/paint-timing/fcp-only/buffered-flag.window.html?label=experimental&label=master&aligned

[Noam Rosenthal]

Created attachment 451507 [details]
Patch

[EWS Watchlist]

This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess

[Noam Rosenthal]

(In reply to EWS Watchlist from comment #5)
> This patch modifies the imported WPT tests. Please ensure that any changes
> on the tests (not coming from a WPT import) are exported to WPT. Please see
> https://trac.webkit.org/wiki/WPTExportProcess

https://github.com/web-platform-tests/wpt/pull/32794

[Noam Rosenthal]

Created attachment 451515 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 451515 [details]
Patch

Please do the test import in a separate bug.

[Noam Rosenthal]

Created attachment 451675 [details]
Patch

[Noam Rosenthal]

(In reply to Simon Fraser (smfr) from comment #8)
> Comment on attachment 451515 [details]
> Patch
> 
> Please do the test import in a separate bug.

Done, this only includes the relevant test.

[Simon Fraser (smfr)]

Comment on attachment 451675 [details]
Patch

If there is an existing test, then import the test first (with a failing result), then land the change. But it would be better to update the entire paint-timing test suite, then make the change.

[Noam Rosenthal]

(In reply to Simon Fraser (smfr) from comment #11)
> Comment on attachment 451675 [details]
> Patch
> 
> If there is an existing test, then import the test first (with a failing
> result), then land the change. But it would be better to update the entire
> paint-timing test suite, then make the change.

Alrighty.

[Noam Rosenthal]

(In reply to Noam Rosenthal from comment #12)
> (In reply to Simon Fraser (smfr) from comment #11)
> > Comment on attachment 451675 [details]
> > Patch
> > 
> > If there is an existing test, then import the test first (with a failing
> > result), then land the change. But it would be better to update the entire
> > paint-timing test suite, then make the change.
> 
> Alrighty.

https://bugs.webkit.org/show_bug.cgi?id=236717

[Noam Rosenthal]

Created attachment 452484 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 452484 [details]
Patch

Perfect.

[EWS]

Committed r290247 (?): <https://commits.webkit.org/r290247>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 452484 [details].