Bug 225305 - PerformanceObserver: buffered flag not working in Paint Timing
Summary: PerformanceObserver: buffered flag not working in Paint Timing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: Safari 14
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Noam Rosenthal
URL:
Keywords: InRadar
: 236155 (view as bug list)
Depends on: 236717
Blocks:
  Show dependency treegraph
 
Reported: 2021-05-03 07:34 PDT by Nicolas
Modified: 2022-02-21 09:51 PST (History)
15 users (show)

See Also:


Attachments
Patch (45.01 KB, patch)
2022-02-10 01:58 PST, Noam Rosenthal
no flags Details | Formatted Diff | Diff
Patch (44.54 KB, patch)
2022-02-10 04:14 PST, Noam Rosenthal
no flags Details | Formatted Diff | Diff
Patch (5.35 KB, patch)
2022-02-11 04:50 PST, Noam Rosenthal
no flags Details | Formatted Diff | Diff
Patch (3.06 KB, patch)
2022-02-17 22:50 PST, Noam Rosenthal
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nicolas 2021-05-03 07:34:39 PDT
The PerformanceObserver's buffered flag is implemented and works in, for instance, Resource Timing. But it does not seem to work in Paint Timing.

Test: go to any website, let it load, then run this on the console:
new PerformanceObserver((l)=>console.log(l.getEntries())).observe({type:'paint', buffered: true})

It is expected to show the Paint Timing entry, but it does not work.

See https://github.com/GoogleChrome/web-vitals/pull/139 for more info.
Comment 1 Radar WebKit Bug Importer 2021-05-10 07:35:17 PDT
<rdar://problem/77746237>
Comment 2 Noam Rosenthal 2022-02-09 10:05:46 PST
*** Bug 236155 has been marked as a duplicate of this bug. ***
Comment 4 Noam Rosenthal 2022-02-10 01:58:37 PST
Created attachment 451507 [details]
Patch
Comment 5 EWS Watchlist 2022-02-10 02:01:11 PST
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess
Comment 6 Noam Rosenthal 2022-02-10 02:12:02 PST
(In reply to EWS Watchlist from comment #5)
> This patch modifies the imported WPT tests. Please ensure that any changes
> on the tests (not coming from a WPT import) are exported to WPT. Please see
> https://trac.webkit.org/wiki/WPTExportProcess

https://github.com/web-platform-tests/wpt/pull/32794
Comment 7 Noam Rosenthal 2022-02-10 04:14:01 PST
Created attachment 451515 [details]
Patch
Comment 8 Simon Fraser (smfr) 2022-02-10 10:31:35 PST
Comment on attachment 451515 [details]
Patch

Please do the test import in a separate bug.
Comment 9 Noam Rosenthal 2022-02-11 04:50:48 PST
Created attachment 451675 [details]
Patch
Comment 10 Noam Rosenthal 2022-02-16 02:02:02 PST
(In reply to Simon Fraser (smfr) from comment #8)
> Comment on attachment 451515 [details]
> Patch
> 
> Please do the test import in a separate bug.

Done, this only includes the relevant test.
Comment 11 Simon Fraser (smfr) 2022-02-16 09:49:30 PST
Comment on attachment 451675 [details]
Patch

If there is an existing test, then import the test first (with a failing result), then land the change. But it would be better to update the entire paint-timing test suite, then make the change.
Comment 12 Noam Rosenthal 2022-02-16 09:53:42 PST
(In reply to Simon Fraser (smfr) from comment #11)
> Comment on attachment 451675 [details]
> Patch
> 
> If there is an existing test, then import the test first (with a failing
> result), then land the change. But it would be better to update the entire
> paint-timing test suite, then make the change.

Alrighty.
Comment 13 Noam Rosenthal 2022-02-16 10:43:13 PST
(In reply to Noam Rosenthal from comment #12)
> (In reply to Simon Fraser (smfr) from comment #11)
> > Comment on attachment 451675 [details]
> > Patch
> > 
> > If there is an existing test, then import the test first (with a failing
> > result), then land the change. But it would be better to update the entire
> > paint-timing test suite, then make the change.
> 
> Alrighty.

https://bugs.webkit.org/show_bug.cgi?id=236717
Comment 14 Noam Rosenthal 2022-02-17 22:50:28 PST
Created attachment 452484 [details]
Patch
Comment 15 Simon Fraser (smfr) 2022-02-21 09:31:42 PST
Comment on attachment 452484 [details]
Patch

Perfect.
Comment 16 EWS 2022-02-21 09:51:49 PST
Committed r290247 (?): <https://commits.webkit.org/r290247>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 452484 [details].