Bug 236705 – [EWS][GTK] Send only one e-mail with all the list of flakies

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Carlos Alberto Lopez Perez]

The current EWS for GTK layout tests is sending one e-mail per flaky detected (one per test).
This seems is too much and we are spamming ourselves.

Change this to only send one e-mail per run with the list of all flakies detected in the body of the e-mail

[Carlos Alberto Lopez Perez]

Created attachment 452198 [details]
Patch

[Aakash Jain]

Ryan what do you think about this?

[Carlos Alberto Lopez Perez]

I'm going to upload a new version that adds unit tests for this, to check that the mail messages are created with the expected content

[Carlos Alberto Lopez Perez]

(In reply to Aakash Jain from comment #2)
> Ryan what do you think about this?

Note that this will only affect the GTK layout tests on the EWS.

The other EWS for layout test (Apple ones) still keep sending one e-mail per flaky test

[Carlos Alberto Lopez Perez]

Created attachment 452213 [details]
Patch

[Ryan Haddad]

(In reply to Carlos Alberto Lopez Perez from comment #4)
> (In reply to Aakash Jain from comment #2)
> > Ryan what do you think about this?
> 
> Note that this will only affect the GTK layout tests on the EWS.
> 
> The other EWS for layout test (Apple ones) still keep sending one e-mail per
> flaky test
Got it, thank you for clarifying!

[Carlos Alberto Lopez Perez]

Created attachment 452226 [details]
Patch

trying EWS

[Carlos Alberto Lopez Perez]

Created attachment 452230 [details]
Patch

trying EWS again, includes also the fixes commented at https://bugs.webkit.org/show_bug.cgi?id=236654#c4

[Carlos Alberto Lopez Perez]

Committed r289947 (247349@trunk): <https://commits.webkit.org/247349@trunk>

[Radar WebKit Bug Importer]

<rdar://problem/89043231>