Bug 236654 - [EWS] Support PRs when sending layout test failure emails
Summary: [EWS] Support PRs when sending layout test failure emails
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-02-15 10:36 PST by Jonathan Bedard
Modified: 2022-02-16 12:55 PST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2022-02-15 10:36:19 PST 
AnalyzeLayoutTestsResults emails change authors when their change fails EWS. We should support pull-requests in this step.
Comment 1 Radar WebKit Bug Importer 2022-02-15 10:36:35 PST 
<rdar://problem/88974170>
Comment 2 Jonathan Bedard 2022-02-15 10:39:56 PST 
Pull request: https://github.com/WebKit/WebKit/pull/147
Comment 3 Jonathan Bedard 2022-02-16 06:48:30 PST 
Landed 247326@main (r289888)
Comment 4 Carlos Alberto Lopez Perez 2022-02-16 12:40:58 PST 
(In reply to Jonathan Bedard from comment #3)
> Landed 247326@main (r289888)

there are a few issues with this patch:

a few _addToLog() calls miss the two parameters needed and there is one variable undefined.

I detected this meanwhile working on bug 236705 which adds unit tests to test the send_email() calls

This would be the fix: http://sprunge.us/BNhsG4

I can include it as part of bug 236705
Comment 5 Carlos Alberto Lopez Perez 2022-02-16 12:55:33 PST 
(In reply to Carlos Alberto Lopez Perez from comment #4)
> (In reply to Jonathan Bedard from comment #3)
> > Landed 247326@main (r289888)
> 
> there are a few issues with this patch:
> 
> a few _addToLog() calls miss the two parameters needed and there is one
> variable undefined.
> 
> I detected this meanwhile working on bug 236705 which adds unit tests to
> test the send_email() calls
> 
> This would be the fix: http://sprunge.us/BNhsG4
> 
> I can include it as part of bug 236705

I landed 289947 that includes also those fixes.

Now the unit tests exercise the code for the send_email_* functions so this should be easier to detect in the future
Comment 6 Carlos Alberto Lopez Perez 2022-02-16 12:55:48 PST 
(In reply to Carlos Alberto Lopez Perez from comment #5)
> (In reply to Carlos Alberto Lopez Perez from comment #4)
> > (In reply to Jonathan Bedard from comment #3)
> > > Landed 247326@main (r289888)
> > 
> > there are a few issues with this patch:
> > 
> > a few _addToLog() calls miss the two parameters needed and there is one
> > variable undefined.
> > 
> > I detected this meanwhile working on bug 236705 which adds unit tests to
> > test the send_email() calls
> > 
> > This would be the fix: http://sprunge.us/BNhsG4
> > 
> > I can include it as part of bug 236705
> 
> I landed 289947 that includes also those fixes.
> 
> Now the unit tests exercise the code for the send_email_* functions so this
> should be easier to detect in the future

r289947