RESOLVED FIXED Bug 236654
[EWS] Support PRs when sending layout test failure emails 
https://bugs.webkit.org/show_bug.cgi?id=236654
Summary [EWS] Support PRs when sending layout test failure emails
Jonathan Bedard
Reported 2022-02-15 10:36:19 PST
AnalyzeLayoutTestsResults emails change authors when their change fails EWS. We should support pull-requests in this step.
Attachments
Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2022-02-15 10:36:35 PST
<rdar://problem/88974170>
Jonathan Bedard
Comment 2 2022-02-15 10:39:56 PST
Pull request: https://github.com/WebKit/WebKit/pull/147
Jonathan Bedard
Comment 3 2022-02-16 06:48:30 PST
Landed 247326@main (r289888)
Carlos Alberto Lopez Perez
Comment 4 2022-02-16 12:40:58 PST
(In reply to Jonathan Bedard from comment #3) > Landed 247326@main (r289888) there are a few issues with this patch: a few _addToLog() calls miss the two parameters needed and there is one variable undefined. I detected this meanwhile working on bug 236705 which adds unit tests to test the send_email() calls This would be the fix: http://sprunge.us/BNhsG4 I can include it as part of bug 236705
Carlos Alberto Lopez Perez
Comment 5 2022-02-16 12:55:33 PST
(In reply to Carlos Alberto Lopez Perez from comment #4) > (In reply to Jonathan Bedard from comment #3) > > Landed 247326@main (r289888) > > there are a few issues with this patch: > > a few _addToLog() calls miss the two parameters needed and there is one > variable undefined. > > I detected this meanwhile working on bug 236705 which adds unit tests to > test the send_email() calls > > This would be the fix: http://sprunge.us/BNhsG4 > > I can include it as part of bug 236705 I landed 289947 that includes also those fixes. Now the unit tests exercise the code for the send_email_* functions so this should be easier to detect in the future
Carlos Alberto Lopez Perez
Comment 6 2022-02-16 12:55:48 PST
(In reply to Carlos Alberto Lopez Perez from comment #5) > (In reply to Carlos Alberto Lopez Perez from comment #4) > > (In reply to Jonathan Bedard from comment #3) > > > Landed 247326@main (r289888) > > > > there are a few issues with this patch: > > > > a few _addToLog() calls miss the two parameters needed and there is one > > variable undefined. > > > > I detected this meanwhile working on bug 236705 which adds unit tests to > > test the send_email() calls > > > > This would be the fix: http://sprunge.us/BNhsG4 > > > > I can include it as part of bug 236705 > > I landed 289947 that includes also those fixes. > > Now the unit tests exercise the code for the send_email_* functions so this > should be easier to detect in the future r289947
Note You need to log in before you can comment on or make changes to this bug.