Bug 236702 – [CSS Container Queries] Size queries on unsupported axis should evaluate to unknown

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Antti Koivisto]

"If ... the query container does not support container size queries on the relevant axes, then the result of evaluating the size feature is unknown.

https://drafts.csswg.org/css-contain-3/#size-container

[Antti Koivisto]

Created attachment 452170 [details]
Patch

[Dean Jackson]

Comment on attachment 452170 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452170&action=review

> Source/WebCore/style/ContainerQueryEvaluator.cpp:203
> +        if (axis == Axis::Width)
> +            axis = container.renderer.isHorizontalWritingMode() ? Axis::Inline : Axis::Block;
> +        else if (axis == Axis::Height)
> +            axis = container.renderer.isHorizontalWritingMode() ? Axis::Block : Axis::Inline;

I guess this is only needed in the ::InlineSize case - maybe it could go there? I don't have strong opinions.

[Antti Koivisto]

> I guess this is only needed in the ::InlineSize case - maybe it could go
> there? I don't have strong opinions.

Good point!

[Antti Koivisto]

Created attachment 452186 [details]
Patch for landing

[EWS]

Committed r289890 (247328@main): <https://commits.webkit.org/247328@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 452186 [details].

[Radar WebKit Bug Importer]

<rdar://problem/89028172>