Bug 236481 - [IFC][Integration] Enable non-paginated vertical-lr writing mode
Summary: [IFC][Integration] Enable non-paginated vertical-lr writing mode
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-02-10 19:55 PST by zalan
Modified: 2022-03-05 09:30 PST (History)
6 users (show)

See Also:

Attachments
Patch (5.13 KB, patch)
2022-02-10 21:12 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (30.76 KB, patch)
2022-02-13 10:26 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (30.82 KB, patch)
2022-02-13 11:34 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (41.63 KB, patch)
2022-02-13 20:37 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (59.16 KB, patch)
2022-02-15 20:42 PST, zalan 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (45.80 KB, patch)
2022-02-16 21:30 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (62.97 KB, patch)
2022-02-18 05:46 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (62.97 KB, patch)
2022-02-18 07:32 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (45.26 KB, patch)
2022-02-18 16:37 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (62.17 KB, patch)
2022-02-18 16:38 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (62.52 KB, patch)
2022-02-18 21:19 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (67.61 KB, patch)
2022-02-19 10:23 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (139.48 KB, patch)
2022-02-19 21:27 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (146.44 KB, patch)
2022-02-20 07:12 PST, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (13) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2022-02-10 19:55:58 PST 
ssia
Comment 1 zalan 2022-02-10 21:12:40 PST 
Created attachment 451638 [details]
Patch
Comment 2 Antti Koivisto 2022-02-10 21:14:15 PST 
Comment on attachment 451638 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=451638&action=review

> Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp:-585
> -    if (!flow.isHorizontalWritingMode())
> -        SET_REASON_AND_RETURN_IF_NEEDED(FlowHasHorizonalWritingMode, reasons, includeReasons);

Finally!
Comment 3 zalan 2022-02-13 10:26:39 PST 
Created attachment 451823 [details]
Patch
Comment 4 zalan 2022-02-13 11:34:46 PST 
Created attachment 451830 [details]
Patch
Comment 5 zalan 2022-02-13 20:37:09 PST 
Created attachment 451855 [details]
Patch
Comment 6 zalan 2022-02-15 20:42:07 PST 
Created attachment 452132 [details]
Patch
Comment 7 zalan 2022-02-16 21:30:31 PST 
Created attachment 452310 [details]
Patch
Comment 8 Radar WebKit Bug Importer 2022-02-17 19:56:18 PST 
<rdar://problem/89123721>
Comment 9 zalan 2022-02-18 05:46:30 PST 
Created attachment 452513 [details]
Patch
Comment 10 zalan 2022-02-18 07:32:24 PST 
Created attachment 452519 [details]
Patch
Comment 11 zalan 2022-02-18 16:37:47 PST 
Created attachment 452604 [details]
Patch
Comment 12 zalan 2022-02-18 16:38:45 PST 
Created attachment 452605 [details]
Patch
Comment 13 zalan 2022-02-18 21:19:14 PST 
Created attachment 452623 [details]
Patch
Comment 14 zalan 2022-02-19 10:23:10 PST 
Created attachment 452645 [details]
Patch
Comment 15 zalan 2022-02-19 21:27:01 PST 
Created attachment 452677 [details]
Patch
Comment 16 zalan 2022-02-20 07:12:58 PST 
Created attachment 452694 [details]
Patch
Comment 17 EWS 2022-02-20 09:54:56 PST 
Committed r290229 (247554@main): <https://commits.webkit.org/247554@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 452694 [details].
Comment 18 Jon Lee 2022-02-20 15:51:40 PST 
This fixed a number of tests. Related bugs, and removed test expectations in r290235.