Bug 214291 - [css-writing-modes] New failures on WPT ref-tests after updating WPT import
Summary: [css-writing-modes] New failures on WPT ref-tests after updating WPT import
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-07-13 19:40 PDT by Carlos Alberto Lopez Perez
Modified: 2022-02-20 15:50 PST (History)
21 users (show)

See Also:


Attachments
Patch (4.86 KB, patch)
2021-05-01 11:24 PDT, Rob Buis
no flags Details | Formatted Diff | Diff
Patch (10.13 KB, patch)
2021-05-02 03:21 PDT, Rob Buis
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (14.19 KB, patch)
2021-05-02 06:44 PDT, Rob Buis
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (14.20 KB, patch)
2021-05-02 08:27 PDT, Rob Buis
no flags Details | Formatted Diff | Diff
Patch (15.03 KB, patch)
2021-05-02 13:14 PDT, Rob Buis
koivisto: review-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Alberto Lopez Perez 2020-07-13 19:40:00 PDT
On bug 214278 the WPT import for css/css-writing-modes tests was updated to WPT e3698c7bb3.

This are the new failures on ref-tests detected:

imported/w3c/web-platform-tests/css/css-writing-modes/abs-pos-with-replaced-child.html [ ImageOnlyFailure ]
imported/w3c/web-platform-tests/css/css-writing-modes/available-size-004.html [ ImageOnlyFailure ]
imported/w3c/web-platform-tests/css/css-writing-modes/available-size-018.html [ ImageOnlyFailure ]
imported/w3c/web-platform-tests/css/css-writing-modes/baseline-with-orthogonal-flow-001.html [ ImageOnlyFailure ]
imported/w3c/web-platform-tests/css/css-writing-modes/direction-upright-001.html [ ImageOnlyFailure ]
imported/w3c/web-platform-tests/css/css-writing-modes/direction-upright-002.html [ ImageOnlyFailure ]
imported/w3c/web-platform-tests/css/css-writing-modes/img-intrinsic-size-contribution-001.html [ ImageOnlyFailure ]
imported/w3c/web-platform-tests/css/css-writing-modes/img-intrinsic-size-contribution-002.html [ ImageOnlyFailure ]
imported/w3c/web-platform-tests/css/css-writing-modes/inline-box-border-vlr-001.html [ ImageOnlyFailure ]
imported/w3c/web-platform-tests/css/css-writing-modes/slr-alongside-vlr-floats.html [ ImageOnlyFailure ]
imported/w3c/web-platform-tests/css/css-writing-modes/srl-alongside-vrl-floats.html [ ImageOnlyFailure ]
imported/w3c/web-platform-tests/css/css-writing-modes/tcy-white-space-processing-001.html [ ImageOnlyFailure ]
imported/w3c/web-platform-tests/css/css-writing-modes/text-orientation-initial.html [ ImageOnlyFailure ]
imported/w3c/web-platform-tests/css/css-writing-modes/wm-propagation-001.html [ ImageOnlyFailure ]
imported/w3c/web-platform-tests/css/css-writing-modes/wm-propagation-body-032.html [ ImageOnlyFailure ]
imported/w3c/web-platform-tests/css/css-writing-modes/wm-propagation-body-033.html [ ImageOnlyFailure ]
imported/w3c/web-platform-tests/css/css-writing-modes/wm-propagation-body-034.html [ ImageOnlyFailure ]
imported/w3c/web-platform-tests/css/css-writing-modes/wm-propagation-body-035.html [ ImageOnlyFailure ]
imported/w3c/web-platform-tests/css/css-writing-modes/wm-propagation-body-036.html [ ImageOnlyFailure ]
imported/w3c/web-platform-tests/css/css-writing-modes/wm-propagation-body-037.html [ ImageOnlyFailure ]
imported/w3c/web-platform-tests/css/css-writing-modes/wm-propagation-body-038.html [ ImageOnlyFailure ]
imported/w3c/web-platform-tests/css/css-writing-modes/wm-propagation-body-039.html [ ImageOnlyFailure ]
imported/w3c/web-platform-tests/css/css-writing-modes/wm-propagation-body-040.html [ ImageOnlyFailure ]
imported/w3c/web-platform-tests/css/css-writing-modes/wm-propagation-body-041.html [ ImageOnlyFailure ]
imported/w3c/web-platform-tests/css/css-writing-modes/wm-propagation-body-042.html [ ImageOnlyFailure ]
imported/w3c/web-platform-tests/css/css-writing-modes/wm-propagation-body-043.html [ ImageOnlyFailure ]
imported/w3c/web-platform-tests/css/css-writing-modes/wm-propagation-body-044.html [ ImageOnlyFailure ]
imported/w3c/web-platform-tests/css/css-writing-modes/wm-propagation-body-045.html [ ImageOnlyFailure ]
imported/w3c/web-platform-tests/css/css-writing-modes/wm-propagation-body-046.html [ ImageOnlyFailure ]
imported/w3c/web-platform-tests/css/css-writing-modes/wm-propagation-body-047.html [ ImageOnlyFailure ]
imported/w3c/web-platform-tests/css/css-writing-modes/wm-propagation-body-048.html [ ImageOnlyFailure ]
imported/w3c/web-platform-tests/css/css-writing-modes/wm-propagation-body-049.html [ ImageOnlyFailure ]
imported/w3c/web-platform-tests/css/css-writing-modes/wm-propagation-body-050.html [ ImageOnlyFailure ]
imported/w3c/web-platform-tests/css/css-writing-modes/wm-propagation-body-051.html [ ImageOnlyFailure ]
imported/w3c/web-platform-tests/css/css-writing-modes/wm-propagation-body-052.html [ ImageOnlyFailure ]
imported/w3c/web-platform-tests/css/css-writing-modes/wm-propagation-body-053.html [ ImageOnlyFailure ]
imported/w3c/web-platform-tests/css/css-writing-modes/wm-propagation-body-054.html [ ImageOnlyFailure ]
imported/w3c/web-platform-tests/css/css-writing-modes/wm-propagation-body-055.html [ ImageOnlyFailure ]
Comment 1 Carlos Alberto Lopez Perez 2020-07-13 21:06:05 PDT
On top of that we have:

* imported/w3c/web-platform-tests/css/css-writing-modes/normal-flow-overconstrained-vlr-005.xht was failing before for all platforms, now only seems to fail for iOS

* imported/w3c/web-platform-tests/css/css-writing-modes/sizing-orthog-htb-in-vrl-013.xht was failing before for all platforms, now only seems to fail for Mac-wk1

And for platform glib (GTK/WPE):

imported/w3c/web-platform-tests/css/css-writing-modes/available-size-004.html [ Pass ]
imported/w3c/web-platform-tests/css/css-writing-modes/available-size-006.html [ Pass ]
imported/w3c/web-platform-tests/css/css-writing-modes/available-size-008.html [ Pass ]
imported/w3c/web-platform-tests/css/css-writing-modes/available-size-009.html [ Pass ]
imported/w3c/web-platform-tests/css/css-writing-modes/available-size-013.html [ Pass ]
imported/w3c/web-platform-tests/css/css-writing-modes/available-size-015.html [ Pass ]
imported/w3c/web-platform-tests/css/css-writing-modes/available-size-016.html [ Pass ]
imported/w3c/web-platform-tests/css/css-writing-modes/available-size-018.html [ Pass ]
imported/w3c/web-platform-tests/css/css-writing-modes/available-size-019.html [ Pass ]
imported/w3c/web-platform-tests/css/css-writing-modes/baseline-with-orthogonal-flow-001.html [ Pass ]
imported/w3c/web-platform-tests/css/css-writing-modes/inline-box-border-vlr-001.html [ Pass ]

For WPE:

imported/w3c/web-platform-tests/css/css-writing-modes/normal-flow-overconstrained-vrl-004.xht [ Pass ]
Comment 2 Radar WebKit Bug Importer 2020-07-20 19:40:12 PDT
<rdar://problem/65861695>
Comment 3 Lauro Moura 2020-07-30 21:37:24 PDT
(In reply to Carlos Alberto Lopez Perez from comment #1)

snip.

> imported/w3c/web-platform-tests/css/css-writing-modes/available-size-013.
> html [ Pass ]

Started image failing somewhere between r265018 (last good, WPE) and r265024 (first bad, both ports).

Maybe related to r265020?
Comment 4 Rob Buis 2021-05-01 11:24:35 PDT
Created attachment 427508 [details]
Patch
Comment 5 Rob Buis 2021-05-02 03:21:57 PDT
Created attachment 427522 [details]
Patch
Comment 6 Rob Buis 2021-05-02 06:44:05 PDT
Created attachment 427524 [details]
Patch
Comment 7 Rob Buis 2021-05-02 08:27:02 PDT
Created attachment 427527 [details]
Patch
Comment 8 Rob Buis 2021-05-02 13:14:36 PDT
Created attachment 427532 [details]
Patch
Comment 9 Antti Koivisto 2021-05-06 01:42:47 PDT
Comment on attachment 427532 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427532&action=review

> Source/WebCore/dom/Element.cpp:3502
> +    const RenderStyle* style = nullptr;
> +    if (allowRenderStyle == AllowRenderStyle::No && document().documentElement() == this) {
> +        if (hasRareData())
> +            style = elementRareData()->computedStyle();
> +        if (!style)
> +            setNodeFlag(NodeFlag::IsComputedStyleInvalidFlag);
> +    } else
> +        style = existingComputedStyle();

It is deeply wrong to insert this sort of hack into our core code to paper over a minor test failure. 

Pretty sure the actual issue here is not properly understood.