Bug 236338 – Account for the sub grid's margin/border/padding on descendant items

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Matt Woodrow]

When children of a sub grid are included into an outer grid's track sizing algorthim, we need to account for the margin/border/padding of the subgrid element itself as part of their intrinsic size.

https://drafts.csswg.org/css-grid-2/#subgrid-item-contribution

[Matt Woodrow]

Created attachment 451979 [details]
Patch

[Matt Woodrow]

Created attachment 451980 [details]
Patch for EWS

[EWS Watchlist]

This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess

[Matt Woodrow]

Created attachment 452078 [details]
Patch

[Radar WebKit Bug Importer]

<rdar://problem/88991969>

[Dean Jackson]

Comment on attachment 452078 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452078&action=review

> LayoutTests/imported/w3c/ChangeLog:12
> +        * web-platform-tests/css/css-grid/subgrid/abs-pos-002-expected.html:
> +        * web-platform-tests/css/css-grid/subgrid/abs-pos-003-expected.html:
> +        * web-platform-tests/css/css-grid/subgrid/line-names-008.html:
> +        * web-platform-tests/css/css-grid/subgrid/parent-repeat-auto-fit-001.html:
> +        * web-platform-tests/css/css-grid/subgrid/parent-repeat-auto-fit-002.html:

What's the plan for getting these changes merged back?

[Matt Woodrow]

(In reply to Dean Jackson from comment #6)
> Comment on attachment 452078 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=452078&action=review
> 
> > LayoutTests/imported/w3c/ChangeLog:12
> > +        * web-platform-tests/css/css-grid/subgrid/abs-pos-002-expected.html:
> > +        * web-platform-tests/css/css-grid/subgrid/abs-pos-003-expected.html:
> > +        * web-platform-tests/css/css-grid/subgrid/line-names-008.html:
> > +        * web-platform-tests/css/css-grid/subgrid/parent-repeat-auto-fit-001.html:
> > +        * web-platform-tests/css/css-grid/subgrid/parent-repeat-auto-fit-002.html:
> 
> What's the plan for getting these changes merged back?

For better or for worse, I figured out these test changes weeks before I had any sort of sanely reviewable WebKit changes, so I uploaded most of them directly to WPT.

I've linked this bug with the WPT pull request for line-names-008.html, but there's also two other WPT pull requests covering these changes.

https://github.com/web-platform-tests/wpt/pull/32611
https://github.com/web-platform-tests/wpt/pull/32585

I'm not sure if I can link multiple WPT pull requests to a single bug, and I'm scared to risk trying and breaking things.

Hopefully those extra two will get approved and pushed.

[Matt Woodrow]

Created attachment 452407 [details]
Patch

[EWS]

Committed r290096 (247446@main): <https://commits.webkit.org/247446@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 452407 [details].