Bug 236337 - Include sub grid items in the track sizing algorithm of the outer grid
Summary: Include sub grid items in the track sizing algorithm of the outer grid
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Matt Woodrow
URL:
Keywords: InRadar
Depends on: 236336
Blocks: 202115 236338
  Show dependency tree / graph
 
Reported: 2022-02-08 15:43 PST by Matt Woodrow
Modified: 2022-02-17 14:55 PST (History)
19 users (show)

See Also:

Attachments
Patch (25.33 KB, patch)
2022-02-08 16:17 PST, Matt Woodrow 		no flags Details | Formatted Diff | Diff
Patch (25.46 KB, patch)
2022-02-14 17:38 PST, Matt Woodrow 		no flags Details | Formatted Diff | Diff
Patch for EWS (116.04 KB, patch)
2022-02-14 17:39 PST, Matt Woodrow 		no flags Details | Formatted Diff | Diff
Patch (21.95 KB, patch)
2022-02-15 10:54 PST, Matt Woodrow 		no flags Details | Formatted Diff | Diff
Patch (21.99 KB, patch)
2022-02-15 12:53 PST, Matt Woodrow 		no flags Details | Formatted Diff | Diff
Patch (22.76 KB, patch)
2022-02-17 11:48 PST, Matt Woodrow 		no flags Details | Formatted Diff | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Woodrow 2022-02-08 15:43:32 PST 
When computing the track sizing of a grid with sub grid items, we should recursively introspect subgrid items and include their children in the sizing computations.
Comment 1 Matt Woodrow 2022-02-08 16:17:43 PST 
Created attachment 451321 [details]
Patch
Comment 2 Matt Woodrow 2022-02-14 17:38:12 PST 
Created attachment 451970 [details]
Patch
Comment 3 Matt Woodrow 2022-02-14 17:39:05 PST 
Created attachment 451971 [details]
Patch for EWS
Comment 4 EWS Watchlist 2022-02-14 17:55:02 PST 
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess
Comment 5 Matt Woodrow 2022-02-15 10:54:45 PST 
Created attachment 452056 [details]
Patch
Comment 6 Matt Woodrow 2022-02-15 12:53:58 PST 
Created attachment 452075 [details]
Patch
Comment 7 Radar WebKit Bug Importer 2022-02-15 15:44:20 PST 
<rdar://problem/88991771>
Comment 8 Matt Woodrow 2022-02-17 11:48:13 PST 
Created attachment 452398 [details]
Patch
Comment 9 Truitt Savell 2022-02-17 14:54:03 PST 
Comment on attachment 452398 [details]
Patch

Clearing flags on attachment: 452398

Committed r290077 (247434@trunk): <https://commits.webkit.org/247434@trunk>