WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
236192
RenderLayer: Simplify RenderElement::paint() calls
https://bugs.webkit.org/show_bug.cgi?id=236192
Summary
RenderLayer: Simplify RenderElement::paint() calls
Nikolas Zimmermann
Reported
2022-02-05 16:28:29 PST
RenderLayer: Simplify RenderElement::paint() calls. Introduce "paintOffsetForRenderer(fragment, localPaintingInfo)" inline helper returning: toLayoutPoint(fragment.layerBounds.location() - rendererLocation() + localPaintingInfo.subpixelOffset) Avoid repeating this formula in various places in RenderLayer - unify it.
Attachments
Patch, v1
(7.25 KB, patch)
2022-02-06 03:12 PST
,
Nikolas Zimmermann
no flags
Details
Formatted Diff
Diff
Patch, v2
(7.25 KB, patch)
2022-02-07 05:58 PST
,
Nikolas Zimmermann
simon.fraser
: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Nikolas Zimmermann
Comment 1
2022-02-06 03:12:07 PST
Created
attachment 451033
[details]
Patch, v1
Nikolas Zimmermann
Comment 2
2022-02-06 03:12:24 PST
Will submit to EWS, once 236186 landed.
Nikolas Zimmermann
Comment 3
2022-02-06 04:42:39 PST
The failed builds are expected, the patch went to EWS too early...
Nikolas Zimmermann
Comment 4
2022-02-07 05:58:13 PST
Created
attachment 451084
[details]
Patch, v2
Nikolas Zimmermann
Comment 5
2022-02-08 01:49:15 PST
Thanks Simon for checking!
Nikolas Zimmermann
Comment 6
2022-02-08 01:53:20 PST
Committed
r289360
(
246948@trunk
): <
https://commits.webkit.org/246948@trunk
>
Radar WebKit Bug Importer
Comment 7
2022-02-08 01:54:17 PST
<
rdar://problem/88618973
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug