RESOLVED FIXED 236186
[LBSE] Generalize RenderLayer::renderBoxLocation(), adding support for SVG layers 
https://bugs.webkit.org/show_bug.cgi?id=236186
Summary [LBSE] Generalize RenderLayer::renderBoxLocation(), adding support for SVG la...
Nikolas Zimmermann
Reported 2022-02-05 16:24:29 PST
Prepare RenderLayer/RenderLayerBacking for RenderSVGModelObject support: Rename renderBoxLocation() -> rendererLocation() and extended it to support RenderSVGModelObject.
Attachments
Patch, v1 (21.48 KB, patch)
2022-02-05 16:33 PST, Nikolas Zimmermann 		no flags
DetailsFormatted DiffDiff
Patch, v2 (22.17 KB, patch)
2022-02-06 02:33 PST, Nikolas Zimmermann 		rbuis: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Nikolas Zimmermann
Comment 1 2022-02-05 16:33:13 PST
Created attachment 451011 [details] Patch, v1
Nikolas Zimmermann
Comment 2 2022-02-06 02:33:08 PST
Created attachment 451028 [details] Patch, v2
Nikolas Zimmermann
Comment 3 2022-02-06 02:35:49 PST
Forgot to include the Headers.cmake changes necessary to copy some new SVG headers to PrivateHeaders - patch v1 already included the necessary Xcode project changes, v2 also the CMake related changes.
Rob Buis
Comment 4 2022-02-07 03:27:02 PST
Comment on attachment 451028 [details] Patch, v2 View in context: https://bugs.webkit.org/attachment.cgi?id=451028&action=review > Source/WebCore/Headers.cmake:1917 > + rendering/svg/SVGRenderSupport.h Why is this needed exactly?
Nikolas Zimmermann
Comment 5 2022-02-07 03:30:43 PST
(In reply to Rob Buis from comment #4) > Comment on attachment 451028 [details] > Patch, v2 > > View in context: > https://bugs.webkit.org/attachment.cgi?id=451028&action=review > > > Source/WebCore/Headers.cmake:1917 > > + rendering/svg/SVGRenderSupport.h > > Why is this needed exactly? rendererLocation() is inlined in RenderLayer.h, and therefore RenderLayer.h needs to include RenderBox.h. To generalize this to additionally support RenderSVGModelObject, RenderLayer.h needs to include RenderSVGModelObject.h to be able to perform the is<...>/downcast<...> type system. RenderLayer.h is utilized by projects outside of WebCore utilizing the WebCore PrivateHeaders/. Therefore RenderSVGModelObject.h and all its included need to be marked as 'private headers' in both the Xcode and CMake project files.
Nikolas Zimmermann
Comment 6 2022-02-07 05:53:53 PST
Committed r289210 (246895@trunk): <https://commits.webkit.org/246895@trunk>
Radar WebKit Bug Importer
Comment 7 2022-02-07 05:54:19 PST
<rdar://problem/88568285>
Note You need to log in before you can comment on or make changes to this bug.