Bug 236165 - Update MediaStreamTrack understanding of source type
Summary: Update MediaStreamTrack understanding of source type
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-02-04 16:24 PST by Eric Carlson
Modified: 2022-02-04 21:34 PST (History)
9 users (show)

See Also:

Attachments
Patch (14.25 KB, patch)
2022-02-04 16:40 PST, Eric Carlson 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (14.24 KB, patch)
2022-02-04 16:52 PST, Eric Carlson 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (14.24 KB, patch)
2022-02-04 17:36 PST, Eric Carlson 		no flags Details | Formatted Diff | Diff
Patch (15.56 KB, patch)
2022-02-04 18:40 PST, Eric Carlson 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2022-02-04 16:24:26 PST 
Bug 235838 changed RealtimeMediaSource::type() to have more than 'audio' and 'video', but didn't update MediaStream/MediaStreamTrack accordingly.
Comment 1 Radar WebKit Bug Importer 2022-02-04 16:24:37 PST 
<rdar://problem/88513632>
Comment 2 Eric Carlson 2022-02-04 16:40:21 PST 
Created attachment 450949 [details]
Patch
Comment 3 Jer Noble 2022-02-04 16:42:43 PST 
Comment on attachment 450949 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450949&action=review

> Source/WebCore/ChangeLog:11
> +        wasn't updated to account for the. Instead of checking a source's type, use the new

"wasn't updated to account for the." 

I'm dying with anticipation!
Comment 4 Eric Carlson 2022-02-04 16:52:55 PST 
Created attachment 450953 [details]
Patch
Comment 5 Eric Carlson 2022-02-04 17:36:43 PST 
Created attachment 450957 [details]
Patch
Comment 6 Eric Carlson 2022-02-04 18:40:03 PST 
Created attachment 450960 [details]
Patch
Comment 7 EWS 2022-02-04 21:34:07 PST 
Committed r289149 (246845@main): <https://commits.webkit.org/246845@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 450960 [details].